From: Patrick Steinhardt <ps@pks.im>
To: Daniel Stenberg <daniel@haxx.se>
Cc: git@vger.kernel.org
Subject: Re: curl 8.10.0 regression breaks uploads with HTTP/2 and http.postbuffer
Date: Fri, 13 Sep 2024 13:21:00 +0200 [thread overview]
Message-ID: <ZuQgFVuokIQs2ZeF@pks.im> (raw)
In-Reply-To: <o8o7sn01-p918-34s5-387p-pprqo7499p8s@unkk.fr>
On Fri, Sep 13, 2024 at 01:04:57PM +0200, Daniel Stenberg wrote:
> On Fri, 13 Sep 2024, Patrick Steinhardt wrote:
>
> > - In there we hit the `large_request` code path. We set up
> > CURLOPT_READFUNCTION and CURLOPT_SEEKFUNCTION. The callback that
> > uses our buffer is the one set up via CURLOPT_READFUNCTION, which is
> > `rpc_out()`.
>
> Thanks, I ended up able to write a stand-alone reproducer. Stefan Eissing
> wrote up a fix that seems to fix the case for us at least and it would be
> great if you could test this in your end:
>
> https://github.com/curl/curl/pull/14895
>
> The actual code patch is tiny. The PR is mostly about adding test cases to
> reproduce and verify.
I can confirm that this pull request fixes the regression. Thanks a
bunch for the quick turnaround, highly appreciated!
Patrick
next prev parent reply other threads:[~2024-09-13 11:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 5:16 curl 8.10.0 regression breaks uploads with HTTP/2 and http.postbuffer Patrick Steinhardt
2024-09-13 6:11 ` Daniel Stenberg
2024-09-13 6:15 ` Daniel Stenberg
2024-09-13 6:36 ` Patrick Steinhardt
2024-09-13 7:49 ` Daniel Stenberg
2024-09-13 8:20 ` Patrick Steinhardt
2024-09-13 11:04 ` Daniel Stenberg
2024-09-13 11:21 ` Patrick Steinhardt [this message]
2024-09-19 19:11 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZuQgFVuokIQs2ZeF@pks.im \
--to=ps@pks.im \
--cc=daniel@haxx.se \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).