From: Patrick Steinhardt <ps@pks.im>
To: karthik nayak <karthik.188@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/3] refs/reftable: introduce "reftable.lockTimeout"
Date: Wed, 18 Sep 2024 06:31:21 +0200 [thread overview]
Message-ID: <ZupXmXtFzw6GuGGT@pks.im> (raw)
In-Reply-To: <CAOLa=ZTja-nFmKZ8iyyp0szuaAWAnPncy0E6rM5=WWgnr=01uA@mail.gmail.com>
On Tue, Sep 17, 2024 at 01:46:39PM -0400, karthik nayak wrote:
> Patrick Steinhardt <ps@pks.im> writes:
>
> [snip]
>
> > +reftable.lockTimeout::
> > + Whenever the reftable backend appends a new table to the stack, it has
> > + to lock the central "tables.list" file before updating it. This config
> > + controls how long the process will wait to acquire the lock in case
> > + another process has already acquired it. Default is 1000 (i.e., retry
> > + for 1 second).
>
> Isn't the default 100ms? As that was what was mentioned in the commit
> message
Oh, yeah. I ended up changing it. 1 second is the default timeout used
by packed-refs, 100ms is the default timeout used by loose refs. The
reason why I ultimately picked 100ms over 1s is that our usecase is
closer to loose refs, because it is our "normal" code path that we hit
whenever we write reftables.
Will fix.
Patrick
next prev parent reply other threads:[~2024-09-18 4:31 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-17 13:43 [PATCH 0/3] reftable: graceful concurrent writes Patrick Steinhardt
2024-09-17 13:43 ` [PATCH 1/3] refs/reftable: introduce "reftable.lockTimeout" Patrick Steinhardt
2024-09-17 17:46 ` karthik nayak
2024-09-17 17:50 ` Eric Sunshine
2024-09-18 4:31 ` Patrick Steinhardt
2024-09-18 4:31 ` Patrick Steinhardt [this message]
2024-09-17 13:43 ` [PATCH 2/3] reftable/stack: allow locking of outdated stacks Patrick Steinhardt
2024-09-17 13:43 ` [PATCH 3/3] refs/reftable: reload locked stack when preparing transaction Patrick Steinhardt
2024-09-17 18:26 ` [PATCH 0/3] reftable: graceful concurrent writes karthik nayak
2024-09-18 4:31 ` Patrick Steinhardt
2024-09-18 4:32 ` [PATCH v2 " Patrick Steinhardt
2024-09-18 4:32 ` [PATCH v2 1/3] refs/reftable: introduce "reftable.lockTimeout" Patrick Steinhardt
2024-09-18 9:22 ` James Liu
2024-09-18 9:39 ` Patrick Steinhardt
2024-09-18 4:32 ` [PATCH v2 2/3] reftable/stack: allow locking of outdated stacks Patrick Steinhardt
2024-09-18 9:26 ` James Liu
2024-09-18 9:39 ` Patrick Steinhardt
2024-09-18 4:32 ` [PATCH v2 3/3] refs/reftable: reload locked stack when preparing transaction Patrick Steinhardt
2024-09-18 9:33 ` [PATCH v2 0/3] reftable: graceful concurrent writes James Liu
2024-09-18 9:59 ` [PATCH v3 " Patrick Steinhardt
2024-09-18 9:59 ` [PATCH v3 1/3] refs/reftable: introduce "reftable.lockTimeout" Patrick Steinhardt
2024-09-19 21:34 ` Junio C Hamano
2024-09-18 9:59 ` [PATCH v3 2/3] reftable/stack: allow locking of outdated stacks Patrick Steinhardt
2024-09-20 18:10 ` Junio C Hamano
2024-09-24 5:33 ` Patrick Steinhardt
2024-09-18 9:59 ` [PATCH v3 3/3] refs/reftable: reload locked stack when preparing transaction Patrick Steinhardt
2024-09-18 23:23 ` [PATCH v3 0/3] reftable: graceful concurrent writes James Liu
2024-09-24 5:33 ` Patrick Steinhardt
2024-09-24 5:32 ` [PATCH v4 " Patrick Steinhardt
2024-09-24 5:33 ` [PATCH v4 1/3] refs/reftable: introduce "reftable.lockTimeout" Patrick Steinhardt
2024-09-24 5:33 ` [PATCH v4 2/3] reftable/stack: allow locking of outdated stacks Patrick Steinhardt
2024-09-24 5:33 ` [PATCH v4 3/3] refs/reftable: reload locked stack when preparing transaction Patrick Steinhardt
2024-09-27 4:07 ` Jeff King
2024-09-30 6:49 ` Patrick Steinhardt
2024-09-30 22:19 ` Josh Steadmon
2024-10-01 4:27 ` Patrick Steinhardt
2024-10-01 22:54 ` Jeff King
2024-10-01 23:24 ` Junio C Hamano
2024-10-02 10:58 ` Patrick Steinhardt
2024-10-01 7:34 ` Junio C Hamano
2024-10-01 18:53 ` Josh Steadmon
2024-10-01 19:08 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZupXmXtFzw6GuGGT@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).