From: Taylor Blau <me@ttaylorr.com>
To: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Emily Shaffer <nasamuffin@google.com>,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Subject: Re: [PATCH] Documentation: mention the amlog in howto/maintain-git.txt
Date: Wed, 2 Oct 2024 11:04:29 -0400 [thread overview]
Message-ID: <Zv1g/dKlLJ2FoEvG@nand.local> (raw)
In-Reply-To: <ff2909b2-3526-4628-bb11-b3a09066a7a6@app.fastmail.com>
On Mon, Sep 30, 2024 at 11:06:03PM +0200, Kristoffer Haugsbakk wrote:
> > @@ -165,6 +165,22 @@ by doing the following:
> > In practice, almost no patch directly goes to 'master' or
> > 'maint'.
> >
> > + The maintainer is expected to update refs/notes/amlog with a
> > + mapping between the applied commit and the 'Message-Id'
> > + corresponding to the e-mail which carried the patch.
> > +
> > + This mapping is created with the aid of the "post-applypatch" hook
> > + found in the 'todo' branch. That hook should be installed before
> > + applying patches. It is also helpful to carry forward any relevant
> > + amlog entries when rebasing, so the following config may be useful:
> > +
> > + [notes]
> > + rewriteref = refs/notes/amlog
>
> Nit: `[notes]` is indented with spaces while the next line is indented
> with a tab. I guess it’s supposed to just be spaces in this context?
Oops, good catch, thanks.
> It might be worth explicitly mentioning the git-cherry-pick(1) footgun
> that Junio talked about in his email: you have to restrict yourself to
> git-rebase(1) and `git commit --amend`. Since git-cherry-pick(1)
> doesn’t care about (respect?) this configuration.
I think that's worth mentioning, and I added a small tidbit in the
latest round mentioning it, thanks.
Thanks,
Taylor
next prev parent reply other threads:[~2024-10-02 15:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 16:21 Linking topic merges to mailing list threads Emily Shaffer
2024-09-30 16:57 ` Konstantin Ryabitsev
2024-09-30 19:30 ` Junio C Hamano
2024-09-30 20:45 ` [PATCH] Documentation: mention the amlog in howto/maintain-git.txt Taylor Blau
2024-09-30 21:06 ` Kristoffer Haugsbakk
2024-10-02 15:04 ` Taylor Blau [this message]
2024-09-30 21:54 ` Junio C Hamano
2024-10-02 15:05 ` Taylor Blau
2024-10-02 15:03 ` [PATCH v2] " Taylor Blau
2024-10-02 19:47 ` Junio C Hamano
2024-10-03 1:09 ` Taylor Blau
2024-10-03 1:09 ` [PATCH v3] " Taylor Blau
2024-10-03 17:23 ` Junio C Hamano
2024-10-03 18:32 ` Ramsay Jones
2024-10-03 18:44 ` Taylor Blau
2024-09-30 20:41 ` Linking topic merges to mailing list threads Kristoffer Haugsbakk
2024-10-02 22:50 ` Eric Wong
2024-10-02 23:34 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zv1g/dKlLJ2FoEvG@nand.local \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=konstantin@linuxfoundation.org \
--cc=kristofferhaugsbakk@fastmail.com \
--cc=nasamuffin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).