From: Patrick Steinhardt <ps@pks.im>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: GIT Mailing-list <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: v2.47.0-rc1 test failure on cygwin
Date: Fri, 4 Oct 2024 05:59:30 +0200 [thread overview]
Message-ID: <Zv9oIrKveu-JAGQM@pks.im> (raw)
In-Reply-To: <b1b5fb40-f6c2-4621-b58c-9b7c8c64cc01@ramsayjones.plus.com>
On Fri, Oct 04, 2024 at 02:02:44AM +0100, Ramsay Jones wrote:
> Hi Patrick,
>
> Just a quick heads up: t0610-reftable-basics.sh test 47 (ref transaction: many
> concurrent writers) fails on cygwin. The tail end of the debug output for this
> test looks like:
>
[snip]
>
> t0610-reftable-basics.sh passed on 'rc0', but this test (and the timeout facility)
> is new in 'rc1'. I tried simply increasing the timeout (10 fold), but that didn't
> change the result. (I didn't really expect it to - the 'reftable: transaction
> prepare: I/O error' does not look timing related!).
>
> Again, just a heads up. (I can't look at it until tomorrow now; any ideas?)
This failure is kind of known and discussed in [1]. Just to make it
explicit: this test failure doesn't really surface a regression, the
reftable code already failed for concurrent writes before. I fixed that
and added the test that is now flaky, as the fix itself is seemingly
only sufficient on Linux and macOS.
I didn't yet have the time to look at whether I can fix it, but should
finally find the time to do so today.
Patrick
[1]: <20240927040752.GA567671@coredump.intra.peff.net>
next prev parent reply other threads:[~2024-10-04 3:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 1:02 v2.47.0-rc1 test failure on cygwin Ramsay Jones
2024-10-04 3:59 ` Patrick Steinhardt [this message]
2024-10-04 6:13 ` Patrick Steinhardt
2024-10-04 9:13 ` Johannes Schindelin
2024-10-04 10:09 ` Patrick Steinhardt
2024-10-04 11:11 ` Johannes Schindelin
2024-10-04 11:32 ` Patrick Steinhardt
2024-10-04 16:09 ` Junio C Hamano
2024-10-04 17:14 ` Patrick Steinhardt
2024-10-04 17:54 ` Junio C Hamano
2024-10-04 12:16 ` [PATCH] t0610: work around flaky test with concurrent writers Patrick Steinhardt
2024-10-04 14:47 ` Ramsay Jones
2024-10-04 15:26 ` Patrick Steinhardt
2024-10-04 16:32 ` Junio C Hamano
2024-10-04 16:22 ` Junio C Hamano
2024-10-04 15:32 ` [PATCH v2] " Patrick Steinhardt
2024-10-04 16:32 ` Ramsay Jones
2024-10-04 16:35 ` Junio C Hamano
2024-10-04 22:41 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zv9oIrKveu-JAGQM@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).