From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Toon Claes <toon@iotcl.com>, git@vger.kernel.org
Subject: Re: [PATCH] builtin/clone: teach git-clone(1) the --ref= argument
Date: Fri, 27 Sep 2024 19:29:41 +0000 [thread overview]
Message-ID: <ZvcHpd26te8TPacz@tapette.crustytoothpaste.net> (raw)
In-Reply-To: <xmqqikuggaz5.fsf@gitster.g>
[-- Attachment #1: Type: text/plain, Size: 2067 bytes --]
On 2024-09-27 at 19:20:14, Junio C Hamano wrote:
> Toon Claes <toon@iotcl.com> writes:
>
> > It's pretty similar to --branch and
> > while --branch takes a branch name or tag name, it doesn't take a fully
> > qualified reference. This allows the user to clone a reference that
> > doesn't start with refs/heads or refs/tags. This can be useful when the
> > server uses custom references.
>
> "when the server uses custom references" is a rather weak
> explanation.
>
> The answer to "Doctor, it hurts when I turn my elbow in this
> unnatural direction" is usually "Well, do not do it then". The
> answer to "Doctor, I cannot use the --branch option because I use
> non branches to keep track of some histories" should be the same.
> Why do you want to turn your elbow in an unnatural angle in the
> first place?
I can't speak for what Toon intended here, but GitHub uses some
references under `refs/pull` that are used for tracking pull requests.
We even have some in the Git repository on GitHub:
% git ls-remote upstream refs/pull/* | head -n 5
f0d0fd3a5985d5e588da1e1d11c85fba0ae132f8 refs/pull/10/head
c8198f6c2c9fc529b25988dfaf5865bae5320cb5 refs/pull/10/merge
d604669e32e847c2ba5010c89895dd707ba45f55 refs/pull/100/head
55ab0c9399879683b4cc6e1baea5dc41484ca52f refs/pull/100/merge
08d39e0bb5b9dbd16e9e4c2250e75848718c453b refs/pull/1000/head
These are not kept under `refs/heads` because `refs/heads` belongs to
the user, but it is generally useful to check them out in case of very
large changes or changes with complex binary files which don't render
well in the web interface (among other reasons) that might need to be
inspected for code review. So I think this is a generally useful
feature, although I agree that perhaps the commit message might explain
the benefits in a more concrete way for those who don't already
understand the utility of the feature (such as our illustrious
maintainer).
--
brian m. carlson (they/them or he/him)
Toronto, Ontario, CA
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2024-09-27 19:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-27 8:54 [PATCH] builtin/clone: teach git-clone(1) the --ref= argument Toon Claes
2024-09-27 19:20 ` Junio C Hamano
2024-09-27 19:29 ` brian m. carlson [this message]
2024-09-27 20:05 ` Junio C Hamano
2024-09-27 20:10 ` Kristoffer Haugsbakk
-- strict thread matches above, loose matches on Subject: below --
2024-07-22 8:07 [PATCH] fetch: use bundle URIs when having creationToken heuristic Toon Claes
2024-09-27 9:04 ` [PATCH] builtin/clone: teach git-clone(1) the --ref= argument Toon Claes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvcHpd26te8TPacz@tapette.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=toon@iotcl.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).