From: Patrick Steinhardt <ps@pks.im>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/4] refs: deprecate core.preferSymlinkRefs
Date: Mon, 30 Sep 2024 10:45:16 +0200 [thread overview]
Message-ID: <ZvplHGpWxwRGWo_4@pks.im> (raw)
In-Reply-To: <20240918232825.2627999-2-gitster@pobox.com>
On Wed, Sep 18, 2024 at 04:28:22PM -0700, Junio C Hamano wrote:
> diff --git a/refs/files-backend.c b/refs/files-backend.c
> index c7f3f4e591..c40a248b9f 100644
> --- a/refs/files-backend.c
> +++ b/refs/files-backend.c
> @@ -2025,6 +2025,8 @@ static int create_ref_symlink(struct ref_lock *lock, const char *target)
>
> if (ret)
> fprintf(stderr, "no symlink - falling back to symbolic ref\n");
> + else
> + warning("core.preferSymlinkRefs will be removed in Git 3.0");
> return ret;
> }
> #endif
This string should probably be marked for translation, right?
Patrick
next prev parent reply other threads:[~2024-09-30 8:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-18 23:28 [PATCH 0/4] deprecating core.preferSymlinkRefs Junio C Hamano
2024-09-18 23:28 ` [PATCH 1/4] refs: deprecate core.preferSymlinkRefs Junio C Hamano
2024-09-30 8:45 ` Patrick Steinhardt [this message]
2024-09-18 23:28 ` [PATCH 2/4] refs: mostly remove core.preferSymlinkRefs Junio C Hamano
2024-09-30 19:28 ` Jeff King
2024-09-30 20:13 ` Junio C Hamano
2024-09-18 23:28 ` [PATCH 3/4] refs: remove NO_SYMLINK_HEAD Junio C Hamano
2024-09-18 23:28 ` [PATCH 4/4] refs: remove the last remnants of core.preferSymlinkRefs Junio C Hamano
2024-09-18 23:38 ` [PATCH 0/4] deprecating core.preferSymlinkRefs Derrick Stolee
2024-09-19 0:26 ` Junio C Hamano
2024-09-30 8:45 ` Patrick Steinhardt
2024-09-30 18:21 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvplHGpWxwRGWo_4@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).