From: Patrick Steinhardt <ps@pks.im>
To: Philippe Blain via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Philippe Blain <levraiphilippeblain@gmail.com>
Subject: Re: [PATCH v2] Makefile: fix dependency for $(UNIT_TEST_DIR)/clar/clar.o
Date: Mon, 14 Oct 2024 13:59:25 +0200 [thread overview]
Message-ID: <Zw0HmISykehEiC-p@pks.im> (raw)
In-Reply-To: <pull.1810.v2.git.1728667787227.gitgitgadget@gmail.com>
On Fri, Oct 11, 2024 at 05:29:47PM +0000, Philippe Blain via GitGitGadget wrote:
> From: Philippe Blain <levraiphilippeblain@gmail.com>
>
> The clar source file '$(UNIT_TEST_DIR)/clar/clar.c' includes the
> generated 'clar.suite', but this dependency is not taken into account by
> our Makefile, so that it is possible for a parallel build to fail if
> Make tries to build 'clar.o' before 'clar.suite' is generated.
>
> Correctly specify the dependency.
>
> Signed-off-by: Philippe Blain <levraiphilippeblain@gmail.com>
Thanks, this version looks good to me.
Patrick
next prev parent reply other threads:[~2024-10-14 11:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 17:43 [PATCH] Makefile: fix dependency for $(UNIT_TEST_DIR)/clar/clar.o Philippe Blain via GitGitGadget
2024-10-08 0:53 ` Junio C Hamano
2024-10-08 3:58 ` Patrick Steinhardt
2024-10-10 12:04 ` Philippe Blain
2024-10-10 18:50 ` Junio C Hamano
2024-10-11 17:29 ` [PATCH v2] " Philippe Blain via GitGitGadget
2024-10-14 11:59 ` Patrick Steinhardt [this message]
2024-10-15 0:34 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zw0HmISykehEiC-p@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=levraiphilippeblain@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).