From: Patrick Steinhardt <ps@pks.im>
To: "Gabriel Nützi" <gnuetzi@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Karthik Nayak <karthik.188@gmail.com>
Subject: Re: Bug: `git init` with hook `reference-transaction` running `git rev-parse --git-dir` fails
Date: Mon, 14 Oct 2024 14:25:27 +0200 [thread overview]
Message-ID: <Zw0NskRJUSmpNxLe@pks.im> (raw)
In-Reply-To: <B0631C6D-0914-4C25-AAF7-E742129836FC@gmail.com>
On Fri, Oct 11, 2024 at 12:09:18PM +0200, Gabriel Nützi wrote:
> > namely by checking whether the HEAD file exists in the Git directory.
>
> The problem here is the chicken-egg problem: How do I know inside a
> hook where to look for HEAD, so the non. env. way of doing this would
> be 'git rev-parse —git-dir' which crahshes… So there should be cleary
> some better way of knowing if a Git repo is on the way of beeing
> created, and when it is fully initialized. What about
> GIT_DIR_INITIALIZING and this variable does not exist once it is done
> or whats about making ‚git rev-parse —git-dir‘ not panic if the env.
> variables are defined. I guess for a good solution we need both?
Our documentation in githooks(5) says that the GIT_DIR environment
variable is always set so that the hook can identify the location of the
Git repository. So I'd argue that using git-rev-parse(1) is unnecessary
in the first place. Or am I missing something?
Patrick
next prev parent reply other threads:[~2024-10-14 12:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-20 10:07 Bug: `git init` with hook `reference-transaction` running `git rev-parse --git-dir` fails Gabriel Nützi
2024-09-20 10:42 ` Gabriel Nützi
2024-10-07 8:03 ` Patrick Steinhardt
2024-10-07 10:54 ` Gabriel Nützi
2024-10-07 10:57 ` Patrick Steinhardt
2024-10-07 11:02 ` Gabriel Nützi
2024-10-07 11:24 ` Patrick Steinhardt
2024-10-07 21:02 ` Junio C Hamano
2024-10-09 9:39 ` Patrick Steinhardt
2024-10-09 10:09 ` Karthik Nayak
2024-10-09 11:53 ` Gabriel Nützi
2024-10-09 12:19 ` Patrick Steinhardt
[not found] ` <B0631C6D-0914-4C25-AAF7-E742129836FC@gmail.com>
2024-10-14 12:25 ` Patrick Steinhardt [this message]
2024-10-09 17:31 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zw0NskRJUSmpNxLe@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=gnuetzi@gmail.com \
--cc=karthik.188@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).