Re: [PATCH 00/10] reftable: stop using `struct strbuf`

[Patrick Steinhardt <ps@pks.im>]

On Fri, Oct 11, 2024 at 05:18:26AM -0700, karthik nayak wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> 
> > Hi,
> >
> > this is the second patch series on my quest to make the reftable library
> > become a standalone library again that can be used by libgit2 without
> > pulling in all kinds of dependencies from the Git codebase. This part
> > makes us lose the dependency on `struct strbuf`, which is done due to
> > three reasons:
> >
> >   - To make us independent of libgit.a.
> >
> >   - To ensure that we use the pluggable allocators that users can set up
> >     via `reftable_set_alloc()`.
> >
> >   - To make it possible to handle memory allocation failures.
> >
> > While this leads to some duplication, we're only talking about ~70 lines
> > of code.
> >
> 
> I only have a few small comments, but overall this series looks good.
> Thanks

Thanks for your review!

Patrick