git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: David Moberg <kaddkaka@gmail.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: git rebase exec make -C in worktree confuses repo root dir
Date: Mon, 14 Oct 2024 17:19:35 -0400	[thread overview]
Message-ID: <Zw2K5xJAOGWitfXr@nand.local> (raw)
In-Reply-To: <CAL2+Miudq0UXAb=R24v+ftZVkHy2We1CFsFAt__tCYMWtCfOow@mail.gmail.com>

On Mon, Oct 14, 2024 at 10:46:45PM +0200, David Moberg wrote:
> What did you expect to happen? (Expected behavior)
>
> 1. This command should return the worktree toplevel, not a subdirectory
>   $ git rev-parse --show-toplevel
>   /tmp/tmp.DUUAVQCIKe/repo2
>
> 2. And the git grep command should return the match from dir/Makefile,
> not Fatal Error
>   $ git grep banana
>   Makefile:       git grep "banana" -- "$$BANANA"

I am not sure if this is expected behavior or not, but it feels
unintentional to me. Perhaps I am missing something funky in your
example that is causing it to behave this way.

Does this bisect to anything interesting, or has it always behaved this
way?

Thanks,
Taylor

  reply	other threads:[~2024-10-14 21:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-14 20:46 git rebase exec make -C in worktree confuses repo root dir David Moberg
2024-10-14 21:19 ` Taylor Blau [this message]
2024-10-14 21:34   ` David Moberg
2024-10-15  7:11   ` Eric Sunshine
2024-10-15 18:55     ` David Moberg
2024-10-15 20:01       ` Eric Sunshine
2024-10-16  9:15         ` Phillip Wood
2024-10-16 20:36           ` Taylor Blau
2024-10-17 21:16             ` Elijah Newren
2024-10-16 21:12           ` Eric Sunshine
2024-11-05 15:24             ` phillip.wood123
     [not found] <1730787532-3757-mlmmj-5e7be4fc@vger.kernel.org>
     [not found] ` <CAL2+Mivva3AFR4of0-2d48YDDMbHiNVsUmCzhezHfe+h9faEvQ@mail.gmail.com>
     [not found]   ` <CAPig+cTVfNW4AFJKyGbRcy0_YJEJGcNYNx57USyp4zz1g9fSeQ@mail.gmail.com>
2024-11-28 15:07     ` Phillip Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zw2K5xJAOGWitfXr@nand.local \
    --to=me@ttaylorr.com \
    --cc=git@vger.kernel.org \
    --cc=kaddkaka@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).