From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C80415575E for ; Mon, 14 Oct 2024 21:40:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728942034; cv=none; b=Zdf1O5T+0dA7I8oxxX8w+MTiIb6HXCehMpBuy/6Omzl5Kn/kKOgx3nJLqzkG1XOs9IyuW9jebOxBfnPWjvZcs8hD0rtfKLMcKp71JuwiD1bBxibHcIETzE+OMjBkQToze7cK7V0qPuJT/NG9iQc23NcIPhqezxnIhM4rdKaWz3E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728942034; c=relaxed/simple; bh=It0OVqv1uXEcpmXMyxr33+cSTA4Fy5S6eqTBkSfbqWU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EGNs0SEKcdr5N4j4cMVYTIyOSayONQCKJfA608dAZ4xxJgemjt3QkccdgvbToPBErBtHi4P+mZ7JxUjHZYS+TbcFjpXQ56zsVlpsDvdEX8hzgxr9RyHFFiMardAbYoqtI44qzM3MiVHt3i/kcb3ZfWE3/TSXVYlHGOLP61GVhOE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ttaylorr.com; spf=pass smtp.mailfrom=ttaylorr.com; dkim=pass (2048-bit key) header.d=ttaylorr-com.20230601.gappssmtp.com header.i=@ttaylorr-com.20230601.gappssmtp.com header.b=GGKoRMRD; arc=none smtp.client-ip=209.85.128.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ttaylorr.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ttaylorr.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ttaylorr-com.20230601.gappssmtp.com header.i=@ttaylorr-com.20230601.gappssmtp.com header.b="GGKoRMRD" Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-6dbc9a60480so39402127b3.0 for ; Mon, 14 Oct 2024 14:40:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ttaylorr-com.20230601.gappssmtp.com; s=20230601; t=1728942032; x=1729546832; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=It0OVqv1uXEcpmXMyxr33+cSTA4Fy5S6eqTBkSfbqWU=; b=GGKoRMRDsu1z3JZWH+XTaHRRjP46nDTRCl4/9Hp/hWkArcCovuYZTshmACE/GMl+jq I9JwWKuWY1mqOWArFU3mUU9vL2uZj+AmPMOz4TMZtPZY3SukMXQPNjSiBgDcut7pwWE2 YszufUq5PAe2R0y4Za6PkIjKUSyHs10ZYWE/oTghJPb2UMvTy+lMUxdbdK+RQN98E6By xQHgp0nxnQfXz6BxklJUvC4rq9G8J4GAleLGTQmkBjllt9QG5idHJUNFRADhHjy3cakp kHdfRKM4P6jscyLRaVGaB9KMnwOG2xempr3w8+qHXQfiRLiY4iOsfrgKMFsEr5tvoDqZ 6a4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728942032; x=1729546832; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=It0OVqv1uXEcpmXMyxr33+cSTA4Fy5S6eqTBkSfbqWU=; b=tVPytMbeFxJl77qlRAsYhK11yhxH4f2NpEZpIKuij8ZJiKA18EpzauLuGS4dz7DLOC npLaRDH99vRbBurAY6eWe/zIDMegveJs+fhidGzDFFRxvnyFhwMw9lEe3e0KUNxC+xKB 7mJ/Gj4y2GaAVfIW39ib7oYTdYEctPxayGox40TCL8p8SjsG6CRXzKuwRUJlJ2B3PCZM PYYEX+31jFQR976NMKc0bqhQZlPJuSshvp1qQwKEx0Er1V7VAEvTFcEyCcUYj6yYa1Oy 4+Dr8h+ICAVYDUiPj6xAT9o1uh7JqBVKaeRhkRWBrD143U5KP07o7rcoWiuG3PiwvEnh IP0w== X-Gm-Message-State: AOJu0Yzog+P+FYANn09fZ2GbX4BJeCQTWd3tTluM4krzfdA/7k07oFhQ OGMfRp6qYP2IxAdIh+mEBeg23A84fnVnXWjn5HvweNFStaqJii7RT+crGDQ4p8g= X-Google-Smtp-Source: AGHT+IGkc3tcK+dP9tO/ozSlKxwEPf0ZDEvtLpBpEHikJOOcnByxHqTHO0fjjBptBn/tVnEcKkZHqg== X-Received: by 2002:a05:690c:7790:b0:6db:cd39:4dae with SMTP id 00721157ae682-6e347b36888mr73600187b3.33.1728942032008; Mon, 14 Oct 2024 14:40:32 -0700 (PDT) Received: from localhost (104-178-186-189.lightspeed.milwwi.sbcglobal.net. [104.178.186.189]) by smtp.gmail.com with ESMTPSA id 00721157ae682-6e332b8a0a7sm16852067b3.48.2024.10.14.14.40.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Oct 2024 14:40:31 -0700 (PDT) Date: Mon, 14 Oct 2024 17:40:30 -0400 From: Taylor Blau To: Patrick Steinhardt Cc: git@vger.kernel.org, Ed Reel , Johannes Schindelin Subject: Re: [PATCH 0/3] cmake: fix autogenerated clar headers Message-ID: References: Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Mon, Oct 14, 2024 at 04:06:38PM +0200, Patrick Steinhardt wrote: > Hi, > > this small patch series fixes how we set up autogenerated clar headers > in CMake such that the clar builds again. The underlying issue is that > we accidentally added the source directory, not the build directory, to > our list of include directories. I guess this went unnoticed because if > you also happen to use Makefiles in the same repo, we'd have found the > Makefile-generated headers by accident. > > The other two patches unify the infra to generate "clar-decls.h", which > has basically been pulled out of my build system modernization patch > series. > > Taylor: note that this conflicts with the patch series at [1]. The > conflict can be solved by accepting the Makefile of this series here and > adding the following on top of "t/unit-tests/generate-clar-decls.sh": Thanks. I had initially kicked the latter out of 'seen' when applying both to my tree. But when I went back and read the contents of these patches more carefully I saw your note here, which is very much appreciated. Thanks, Taylor