From: Patrick Steinhardt <ps@pks.im>
To: Usman Akinyemi via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,
Christian Couder <christian.couder@gmail.com>,
Phillip Wood Phillip Wood <phillip.wood@dunelm.org.uk>,
Eric Sunshine <sunshine@sunshineco.com>,
shejialuo <shejialuo@gmail.com>,
Usman Akinyemi <usmanakinyemi202@gmail.com>
Subject: Re: [PATCH v3 2/2] [Outreachy][Patch v1] t3404: employing test_line_count() to replace test
Date: Mon, 7 Oct 2024 08:05:03 +0200 [thread overview]
Message-ID: <ZwN6D_-Ak1FoE0ix@pks.im> (raw)
In-Reply-To: <37b1411ee2c420f1a8578d27a2f7d54ccd3f329f.1728230769.git.gitgitgadget@gmail.com>
On Sun, Oct 06, 2024 at 04:06:09PM +0000, Usman Akinyemi via GitGitGadget wrote:
> @@ -401,8 +402,8 @@ test_expect_success 'multi-squash only fires up editor once' '
> ) &&
> test $base = $(git rev-parse HEAD^) &&
> git show >output &&
> - count=$(grep ONCE output | wc -l) &&
> - test 1 = $count
> + grep ONCE output >actual &&
> + test_line_count = 1 actual
> '
>
> test_expect_success 'multi-fixup does not fire up editor' '
Oh, you already do the change I proposed on the first commit. It's a bit
funny that we first change things one way and then touch it up again in
another commit as it leaves the reviewer wondering for a bit.
But I guess that's okay, especially for a microproject. So overall I
don't see a strong reason to reroll this series, thanks!
Patrick
next prev parent reply other threads:[~2024-10-07 6:05 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-06 5:33 [PATCH 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes Usman Akinyemi via GitGitGadget
2024-10-06 5:33 ` [PATCH 1/2] [Outreachy][Patch v1] " Usman Akinyemi via GitGitGadget
2024-10-06 5:55 ` Eric Sunshine
2024-10-06 6:31 ` Usman Akinyemi
2024-10-06 5:33 ` [PATCH 2/2] [Outreachy][Patch v2] " Usman Akinyemi via GitGitGadget
2024-10-06 5:48 ` Eric Sunshine
2024-10-06 6:30 ` Usman Akinyemi
2024-10-06 7:28 ` Eric Sunshine
2024-10-06 8:26 ` Usman Akinyemi
2024-10-06 8:31 ` [PATCH v2] [Outreachy][Patch v1] " Usman Akinyemi via GitGitGadget
2024-10-06 9:19 ` Eric Sunshine
2024-10-06 9:32 ` Usman Akinyemi
2024-10-06 10:21 ` Eric Sunshine
2024-10-06 11:12 ` shejialuo
2024-10-06 12:06 ` Eric Sunshine
2024-10-06 12:28 ` Usman Akinyemi
2024-10-06 13:03 ` shejialuo
2024-10-06 13:27 ` Usman Akinyemi
2024-10-06 13:36 ` shejialuo
2024-10-06 12:29 ` shejialuo
2024-10-06 12:46 ` Usman Akinyemi
2024-10-07 4:19 ` Eric Sunshine
2024-10-06 16:06 ` [PATCH v3 0/2] [Outreachy][Patch v2] " Usman Akinyemi via GitGitGadget
2024-10-06 16:06 ` [PATCH v3 1/2] t3404: avoid losing exit status with focus on `git show` and `git cat-files` Usman Akinyemi via GitGitGadget
2024-10-07 6:04 ` Patrick Steinhardt
2024-10-07 8:52 ` phillip.wood123
2024-10-07 9:05 ` Usman Akinyemi
2024-10-06 16:06 ` [PATCH v3 2/2] [Outreachy][Patch v1] t3404: employing test_line_count() to replace test Usman Akinyemi via GitGitGadget
2024-10-06 16:31 ` Kristoffer Haugsbakk
2024-10-07 4:38 ` Eric Sunshine
2024-10-07 6:05 ` Patrick Steinhardt [this message]
2024-10-07 7:32 ` Usman Akinyemi
2024-10-07 9:00 ` phillip.wood123
2024-10-06 16:18 ` [PATCH v3 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes Usman Akinyemi
2024-10-07 4:24 ` Eric Sunshine
2024-10-07 7:25 ` Usman Akinyemi
2024-10-07 8:08 ` Patrick Steinhardt
2024-10-07 8:11 ` Eric Sunshine
2024-10-07 9:01 ` Usman Akinyemi
2024-10-06 16:21 ` Kristoffer Haugsbakk
2024-10-06 16:26 ` Usman Akinyemi
2024-10-07 5:55 ` Patrick Steinhardt
2024-10-07 10:22 ` [PATCH v4 " Usman Akinyemi via GitGitGadget
2024-10-07 10:22 ` [PATCH v4 1/2] t3404: avoid losing exit status with focus on `git show` and `git cat-file` Usman Akinyemi via GitGitGadget
2024-10-07 10:22 ` [PATCH v4 2/2] [Outreachy][Patch v1] t3404: employing test_line_count() to replace test Usman Akinyemi via GitGitGadget
2024-10-07 10:28 ` Patrick Steinhardt
2024-10-07 10:51 ` [PATCH v5 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes Usman Akinyemi via GitGitGadget
2024-10-07 10:51 ` [PATCH v5 1/2] t3404: avoid losing exit status with focus on `git show` and `git cat-file` Usman Akinyemi via GitGitGadget
2024-10-07 10:51 ` [PATCH v5 2/2] t3404: employing test_line_count() to replace test Usman Akinyemi via GitGitGadget
2024-10-07 10:54 ` Patrick Steinhardt
2024-10-07 11:10 ` Usman Akinyemi
2024-10-07 11:11 ` [PATCH v6 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes Usman Akinyemi via GitGitGadget
2024-10-07 11:11 ` [PATCH v6 1/2] t3404: avoid losing exit status with focus on `git show` and `git cat-file` Usman Akinyemi via GitGitGadget
2024-10-07 11:11 ` [PATCH v6 2/2] t3404: employing test_line_count() to replace test Usman Akinyemi via GitGitGadget
2024-10-07 15:07 ` Phillip Wood
2024-10-07 15:32 ` Usman Akinyemi
2024-10-07 11:12 ` [PATCH v6 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes Patrick Steinhardt
2024-10-07 11:16 ` Usman Akinyemi
2024-10-07 11:32 ` Patrick Steinhardt
2024-10-07 11:44 ` Usman Akinyemi
2024-10-07 15:32 ` [PATCH v7 " Usman Akinyemi via GitGitGadget
2024-10-07 15:32 ` [PATCH v7 1/2] t3404: avoid losing exit status with focus on `git show` and `git cat-file` Usman Akinyemi via GitGitGadget
2024-10-07 15:32 ` [PATCH v7 2/2] t3404: replace test with test_line_count() Usman Akinyemi via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwN6D_-Ak1FoE0ix@pks.im \
--to=ps@pks.im \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
--cc=shejialuo@gmail.com \
--cc=sunshine@sunshineco.com \
--cc=usmanakinyemi202@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).