From: Patrick Steinhardt <ps@pks.im>
To: "Gabriel Nützi" <gnuetzi@gmail.com>
Cc: git@vger.kernel.org, Karthik Nayak <karthik.188@gmail.com>
Subject: Re: Bug: `git init` with hook `reference-transaction` running `git rev-parse --git-dir` fails
Date: Mon, 7 Oct 2024 12:57:19 +0200 [thread overview]
Message-ID: <ZwO-j0C59vuYsEnt@pks.im> (raw)
In-Reply-To: <867f42bea10de470532d2f30eacceafa2b03d8de.camel@gmail.com>
On Mon, Oct 07, 2024 at 12:54:36PM +0200, Gabriel Nützi wrote:
> Hi Patrick,
>
> Thanks for clarifications!
> Could it work if for (2) -> call the reference-transaction hook after the HEAD has been initialized, meaning that Git would internally cache the
> different reference transactions and then call the hooks in one go at once after the creation of the repo, such that it is initialized properly?
> This might be probably a more elaborate change which introduces too many technicalities?
That would break basic assumptions of how the hook operates. It is
expected that we abort the transaction when the hook returns an error,
so if we were to run the hook _after_ `HEAD` has been created that
expectation would be broken.
So the only viable solution is to create a stub `HEAD`, but as said I'm
not a 100% sure whether we want to go there or not.
Patrick
next prev parent reply other threads:[~2024-10-07 10:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-20 10:07 Bug: `git init` with hook `reference-transaction` running `git rev-parse --git-dir` fails Gabriel Nützi
2024-09-20 10:42 ` Gabriel Nützi
2024-10-07 8:03 ` Patrick Steinhardt
2024-10-07 10:54 ` Gabriel Nützi
2024-10-07 10:57 ` Patrick Steinhardt [this message]
2024-10-07 11:02 ` Gabriel Nützi
2024-10-07 11:24 ` Patrick Steinhardt
2024-10-07 21:02 ` Junio C Hamano
2024-10-09 9:39 ` Patrick Steinhardt
2024-10-09 10:09 ` Karthik Nayak
2024-10-09 11:53 ` Gabriel Nützi
2024-10-09 12:19 ` Patrick Steinhardt
[not found] ` <B0631C6D-0914-4C25-AAF7-E742129836FC@gmail.com>
2024-10-14 12:25 ` Patrick Steinhardt
2024-10-09 17:31 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwO-j0C59vuYsEnt@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gnuetzi@gmail.com \
--cc=karthik.188@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).