From: Patrick Steinhardt <ps@pks.im>
To: Junio C Hamano <gitster@pobox.com>
Cc: Josh Heinrichs <joshiheinrichs@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH v2 1/1] git-config.1: remove value from positional args in unset usage
Date: Wed, 9 Oct 2024 05:37:19 +0200 [thread overview]
Message-ID: <ZwX6byY2IVFvKezP@pks.im> (raw)
In-Reply-To: <xmqqfrp61mnz.fsf@gitster.g>
On Tue, Oct 08, 2024 at 11:20:48AM -0700, Junio C Hamano wrote:
> Josh Heinrichs <joshiheinrichs@gmail.com> writes:
>
> > The synopsis for `git config unset` mentions two positional arguments:
> > `<name>` and `<value>`. While the first argument is correct, the second
> > is not. Users are expected to provide the value via `--value=<value>`.
> >
> > Remove the positional argument. The `--value=<value>` option is already
> > documented correctly, so this is all we need to do to fix the
> > documentation.
> >
> > Signed-off-by: Josh Heinrichs <joshiheinrichs@gmail.com>
> > ---
> > Documentation/git-config.txt | 2 +-
> > builtin/config.c | 4 ++--
> > 2 files changed, 3 insertions(+), 3 deletions(-)
>
> Patrick, do you mind to forge your Reviewed-by for this one?
>
> Will queue. Thanks, both.
No, please feel free to add it.
Reviewed-by: Patrick Steinhardt <ps@pks.im>
Patrick
prev parent reply other threads:[~2024-10-09 3:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 4:07 [PATCH 0/1] Remove value from positional args in config unset usage Josh Heinrichs
2024-10-08 4:07 ` [PATCH 1/1] git-config.1: remove value from positional args in " Josh Heinrichs
2024-10-08 12:37 ` Patrick Steinhardt
2024-10-08 14:29 ` [PATCH v2 0/1] Remove value from position args in config " Josh Heinrichs
2024-10-08 14:29 ` [PATCH v2 1/1] git-config.1: remove value from positional args in " Josh Heinrichs
2024-10-08 18:20 ` Junio C Hamano
2024-10-09 3:37 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwX6byY2IVFvKezP@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=joshiheinrichs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).