From: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
To: Josh Steadmon <steadmon@google.com>
Cc: git@vger.kernel.org, eric.sesterhenn@x41-dsec.de, jarlob@gmail.com
Subject: Re: [PATCH 1/3] fuzz: port fuzz-credential-from-url-gently from OSS-Fuzz
Date: Fri, 11 Oct 2024 11:13:15 +0200 [thread overview]
Message-ID: <ZwjsK-uprX0eUAl5@ugly> (raw)
In-Reply-To: <625b8d607ed2c95e396e7794616d9f290f23d15c.1728594659.git.steadmon@google.com>
just some nits:
On Thu, Oct 10, 2024 at 02:11:53PM -0700, Josh Steadmon wrote:
>+++ b/ci/run-build-and-minimal-fuzzers.sh
>+fuzzers="
>+commit-graph \
>+config \
>+credential-from-url-gently \
>+date \
>+pack-headers \
>+pack-idx \
>+"
the trailing space-backslashes can be left out, which would make the
code less noisy. then the variable would contain linebreaks instead of
spaces, which the for loop would be just fine with (as $IFS contains
LF).
>+for fuzzer in $fuzzers ; do
>
the space before the semicolon seems excessive.
>+++ b/oss-fuzz/fuzz-credential-from-url-gently.c
>+int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size);
>+
are these seemingly redundant prototypes meant to suppress compiler
warnings?
>+int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size)
>+{
next prev parent reply other threads:[~2024-10-11 9:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 21:11 [PATCH 0/3] fuzz: port OSS-Fuzz tests back to Git Josh Steadmon
2024-10-10 21:11 ` [PATCH 1/3] fuzz: port fuzz-credential-from-url-gently from OSS-Fuzz Josh Steadmon
2024-10-11 9:13 ` Oswald Buddenhagen [this message]
2024-10-11 16:35 ` Junio C Hamano
2024-10-14 20:35 ` Josh Steadmon
2024-10-14 20:43 ` Josh Steadmon
2024-10-10 21:11 ` [PATCH 2/3] fuzz: port fuzz-parse-attr-line " Josh Steadmon
2024-10-10 21:11 ` [PATCH 3/3] fuzz: port fuzz-url-decode-mem " Josh Steadmon
2024-10-10 21:34 ` [PATCH 0/3] fuzz: port OSS-Fuzz tests back to Git Junio C Hamano
2024-10-14 21:04 ` [PATCH v2 " Josh Steadmon
2024-10-14 21:04 ` [PATCH v2 1/3] fuzz: port fuzz-credential-from-url-gently from OSS-Fuzz Josh Steadmon
2024-10-14 21:04 ` [PATCH v2 2/3] fuzz: port fuzz-parse-attr-line " Josh Steadmon
2024-10-14 21:04 ` [PATCH v2 3/3] fuzz: port fuzz-url-decode-mem " Josh Steadmon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwjsK-uprX0eUAl5@ugly \
--to=oswald.buddenhagen@gmx.de \
--cc=eric.sesterhenn@x41-dsec.de \
--cc=git@vger.kernel.org \
--cc=jarlob@gmail.com \
--cc=steadmon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).