From: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Jeff King <peff@peff.net>
Subject: Re: [PATCH 12/13] INSTALL: require Perl 5.26.0
Date: Fri, 11 Oct 2024 11:38:38 +0200 [thread overview]
Message-ID: <ZwjyHl98xRs9TDQZ@ugly> (raw)
In-Reply-To: <20241010235621.738239-13-sandals@crustytoothpaste.net>
On Thu, Oct 10, 2024 at 11:56:20PM +0000, brian m. carlson wrote:
>Update the INSTALL file to reflect our new dependency requirement.
>
any particular reason not to squash this into the parent commit?
i see how the separation makes sense for the libcurl sub-series, but
that doesn't seem applicable here.
regarding the actual `use` statements, you could make them somewhat more
legible by using 'v5.26' as the version number.
another aspect to consider is that the statement doesn't just specify
the minimal version, but also subtly changes behavior. for example, the
`use strict;` statements become redundant.
cf. https://perldoc.perl.org/functions/use#use-VERSION
lastly, it would be nice to update the build systems to reflect the
version requirements. though the only pre-existing version check i found
is the libcurl one in contrib/buildsystems/CMakeLists.txt.
next prev parent reply other threads:[~2024-10-11 9:38 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 23:56 [PATCH 00/13] Update versions of libcurl and Perl brian m. carlson
2024-10-10 23:56 ` [PATCH 01/13] git-curl-compat: remove check for curl 7.21.5 brian m. carlson
2024-10-10 23:56 ` [PATCH 02/13] git-curl-compat: remove check for curl 7.25.0 brian m. carlson
2024-10-10 23:56 ` [PATCH 03/13] git-curl-compat: remove check for curl 7.34.0 brian m. carlson
2024-10-10 23:56 ` [PATCH 04/13] git-curl-compat: remove check for curl 7.39.0 brian m. carlson
2024-10-10 23:56 ` [PATCH 05/13] git-curl-compat: remove check for curl 7.43.0 brian m. carlson
2024-10-10 23:56 ` [PATCH 06/13] git-curl-compat: remove check for curl 7.44.0 brian m. carlson
2024-10-10 23:56 ` [PATCH 07/13] git-curl-compat: remove check for curl 7.52.0 brian m. carlson
2024-10-10 23:56 ` [PATCH 08/13] git-curl-compat: remove check for curl 7.53.0 brian m. carlson
2024-10-10 23:56 ` [PATCH 09/13] git-curl-compat: remove check for curl 7.56.0 brian m. carlson
2024-10-11 6:48 ` Patrick Steinhardt
2024-10-11 7:33 ` Jeff King
2024-10-11 7:49 ` Patrick Steinhardt
2024-10-11 16:53 ` Junio C Hamano
2024-10-10 23:56 ` [PATCH 10/13] INSTALL: document requirement for libcurl 7.61.0 brian m. carlson
2024-10-10 23:56 ` [PATCH 11/13] Require Perl 5.26.0 brian m. carlson
2024-10-10 23:56 ` [PATCH 12/13] INSTALL: require " brian m. carlson
2024-10-11 9:38 ` Oswald Buddenhagen [this message]
2024-10-15 22:48 ` brian m. carlson
2024-10-10 23:56 ` [PATCH 13/13] gitweb: make use of s///r brian m. carlson
2024-10-11 7:40 ` [PATCH 00/13] Update versions of libcurl and Perl Jeff King
2024-10-11 16:42 ` Junio C Hamano
2024-10-11 18:09 ` Eric Sunshine
2024-10-11 18:35 ` Junio C Hamano
2024-10-11 19:08 ` Alejandro R. Sedeño
2024-10-11 19:22 ` Eric Sunshine
2024-10-11 20:01 ` brian m. carlson
2024-10-15 6:13 ` Eric Sunshine
2024-10-15 19:19 ` Taylor Blau
2024-10-15 23:56 ` [PATCH 00/13] Update versions of libcurl and Perlg brian m. carlson
2024-10-16 2:00 ` Alejandro R. Sedeño
2024-10-22 3:34 ` [PATCH 00/13] Update versions of libcurl and Perl Eli Schwartz
2024-10-22 21:58 ` brian m. carlson
2024-10-11 13:23 ` Alejandro R. Sedeño
2024-10-11 16:48 ` Junio C Hamano
2024-10-14 13:28 ` Alejandro R. Sedeño
2024-10-17 9:16 ` Patrick Steinhardt
2024-10-23 0:45 ` [PATCH v2 00/12] " brian m. carlson
2024-10-23 0:45 ` [PATCH v2 01/12] git-curl-compat: remove check for curl 7.21.5 brian m. carlson
2024-10-23 0:45 ` [PATCH v2 02/12] git-curl-compat: remove check for curl 7.25.0 brian m. carlson
2024-10-23 0:45 ` [PATCH v2 03/12] git-curl-compat: remove check for curl 7.34.0 brian m. carlson
2024-10-23 0:45 ` [PATCH v2 04/12] git-curl-compat: remove check for curl 7.39.0 brian m. carlson
2024-10-23 0:45 ` [PATCH v2 05/12] git-curl-compat: remove check for curl 7.43.0 brian m. carlson
2024-10-23 0:45 ` [PATCH v2 06/12] git-curl-compat: remove check for curl 7.44.0 brian m. carlson
2024-10-23 0:45 ` [PATCH v2 07/12] git-curl-compat: remove check for curl 7.52.0 brian m. carlson
2024-10-23 0:45 ` [PATCH v2 08/12] git-curl-compat: remove check for curl 7.53.0 brian m. carlson
2024-10-23 0:45 ` [PATCH v2 09/12] git-curl-compat: remove check for curl 7.56.0 brian m. carlson
2024-10-23 0:45 ` [PATCH v2 10/12] INSTALL: document requirement for libcurl 7.61.0 brian m. carlson
2024-10-23 0:45 ` [PATCH v2 11/12] Require Perl 5.26.0 brian m. carlson
2024-10-23 1:15 ` rsbecker
2024-10-23 0:46 ` [PATCH v2 12/12] gitweb: make use of s///r brian m. carlson
2024-10-23 12:34 ` Oswald Buddenhagen
2024-10-24 21:52 ` brian m. carlson
2024-10-23 20:16 ` [PATCH v2 00/12] Update versions of libcurl and Perl Taylor Blau
2024-10-24 6:05 ` Patrick Steinhardt
2024-10-24 21:53 ` brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwjyHl98xRs9TDQZ@ugly \
--to=oswald.buddenhagen@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox