git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: "immeëmosol via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, immeëmosol <will+developer@willfris.nl>
Subject: Re: [PATCH] diff-highlight: link to diff-highlight in DESTDIR #Makefile #diff-highlight
Date: Sat, 12 Oct 2024 11:50:53 -0400	[thread overview]
Message-ID: <Zwqa3YFt9+dfKmHM@nand.local> (raw)
In-Reply-To: <pull.938.git.git.1728745399993.gitgitgadget@gmail.com>

On Sat, Oct 12, 2024 at 03:03:19PM +0000, immeëmosol via GitGitGadget wrote:
> diff --git a/contrib/diff-highlight/Makefile b/contrib/diff-highlight/Makefile
> index f2be7cc9243..10c588a7929 100644
> --- a/contrib/diff-highlight/Makefile
> +++ b/contrib/diff-highlight/Makefile
> @@ -9,6 +9,7 @@ diff-highlight: shebang.perl DiffHighlight.pm diff-highlight.perl
>  	cat $^ >$@+
>  	chmod +x $@+
>  	mv $@+ $@
> +	ln --symbolic --target-directory=$(DESTDIR) $(abspath $@)

Hmm. I am not opposed to having diff-highlight's Makefile be responsible
for installing a symbolic link to the generated script, but I do not
think that this Makefile recipe is the right place to do it.

This recipe is about building the executable, not installing it. If you
want to introduce a separate .PHONY recipe for installing the script, I
think that would be a better place to introduce this change.

Thanks,
Taylor

  reply	other threads:[~2024-10-12 15:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-12 15:03 [PATCH] diff-highlight: link to diff-highlight in DESTDIR #Makefile #diff-highlight immeëmosol via GitGitGadget
2024-10-12 15:50 ` Taylor Blau [this message]
2024-10-12 17:30 ` [PATCH v2] diff-highlight: make install link into DESTDIR #Makefile immeëmosol via GitGitGadget
2024-10-12 18:35   ` Kristoffer Haugsbakk
2024-10-12 19:10     ` immeëmosol
2024-10-12 19:22       ` Junio C Hamano
2024-10-12 20:23   ` [PATCH v3] diff-highlight: make install link into DESTDIR immeëmosol via GitGitGadget
2024-10-12 20:55     ` Jeff King
2024-10-12 23:41       ` immeëmosol
2024-10-14  3:29         ` Đoàn Trần Công Danh
2024-10-14 22:17         ` Taylor Blau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zwqa3YFt9+dfKmHM@nand.local \
    --to=me@ttaylorr.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=will+developer@willfris.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).