From: Patrick Steinhardt <ps@pks.im>
To: Andrew Kreimer <algonell@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 0/7] Fix typos
Date: Mon, 14 Oct 2024 12:39:38 +0200 [thread overview]
Message-ID: <Zwz05AIAGLOu_EdD@pks.im> (raw)
In-Reply-To: <20241010151223.311719-1-algonell@gmail.com>
On Thu, Oct 10, 2024 at 06:11:18PM +0300, Andrew Kreimer wrote:
> v2:
> - Fix grammar.
>
> v1:
> - https://lore.kernel.org/all/20241009114940.520486-1-algonell@gmail.com/
>
> Interdiff against v1:
> diff --git a/compat/regex/regexec.c b/compat/regex/regexec.c
> index 15ab2d1d40..2eeec82f40 100644
> --- a/compat/regex/regexec.c
> +++ b/compat/regex/regexec.c
> @@ -292,7 +292,7 @@ compat_symbol (libc, __compat_regexec, regexec, GLIBC_2_0);
> concerned.
>
> If REGS is not NULL, and BUFP->no_sub is not set, the offsets of the match
> - and all groups is stored in REGS. (For the "_2" variants, the offsets are
> + and all groups are stored in REGS. (For the "_2" variants, the offsets are
> computed relative to the concatenation, not relative to the individual
> strings.)
Thanks, the diff compared to v1 looks as expected to me, so this version
is good to go from my point of view.
Patrick
next prev parent reply other threads:[~2024-10-14 10:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 15:11 [PATCH v2 0/7] Fix typos Andrew Kreimer
2024-10-10 15:11 ` [PATCH v2 1/7] compat: fix typos Andrew Kreimer
2024-10-10 15:11 ` [PATCH v2 2/7] contrib: " Andrew Kreimer
2024-10-10 15:11 ` [PATCH v2 3/7] git-gui: Fix typos Andrew Kreimer
2024-10-10 15:11 ` [PATCH v2 4/7] t: fix typos Andrew Kreimer
2024-10-10 15:11 ` [PATCH v2 5/7] t/perf: " Andrew Kreimer
2024-10-10 15:11 ` [PATCH v2 6/7] t/unit-tests: " Andrew Kreimer
2024-10-10 15:11 ` [PATCH v2 7/7] t/helper: fix a typo Andrew Kreimer
2024-10-14 10:39 ` Patrick Steinhardt [this message]
2024-10-15 0:35 ` [PATCH v2 0/7] Fix typos Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zwz05AIAGLOu_EdD@pks.im \
--to=ps@pks.im \
--cc=algonell@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).