From: Taylor Blau <me@ttaylorr.com>
To: kristofferhaugsbakk@fastmail.com
Cc: git@vger.kernel.org, Kristoffer Haugsbakk <code@khaugsbakk.name>,
phillip.wood@dunelm.org.uk, gitster@pobox.com,
bence@ferdinandy.com, karthik.188@gmail.com
Subject: Re: [PATCH 4/6] doc: update-ref: remove confusing paragraph
Date: Wed, 16 Oct 2024 16:51:07 -0400 [thread overview]
Message-ID: <ZxAnO5zH1vtgRvLk@nand.local> (raw)
In-Reply-To: <dec48e2d37cc4edafb51476284ce3fece4718ce7.1729017728.git.code@khaugsbakk.name>
On Tue, Oct 15, 2024 at 09:03:13PM +0200, kristofferhaugsbakk@fastmail.com wrote:
> From: Kristoffer Haugsbakk <code@khaugsbakk.name>
>
> This paragraph interrupts the flow of this section by going into detail
> about what a symbolic ref file is and how it is implemented. It is not
> clear what the purpose is since symbolic refs were already mentioned
> prior (“possibly dereferencing the symbolic refs”). Worse, it can
> confuse the reader about what argument can be a symbolic ref since it
> just says “it” and not which of the parameters; in turn the reader can
> be lead to try `<new-oid>` and then get a confusing error since
> update-ref will just say that it is not a valid SHA1.
I think that it is worth saying that this concept is explained well
throughout other parts of the documentation, including other parts of
'git-update-ref(1)', as well as the glossary content.
I don't think that you necessarily need to mention that here. But at
least I was initially confused thinking that this patch proposed
removing the only mention of the special "ref:" syntax for symbolic
references.
But it does not, so I think that this patch as you wrote it is good.
Let's keep reading...
Thanks,
Taylor
next prev parent reply other threads:[~2024-10-16 20:51 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 20:51 ref: with git update-ref? Bence Ferdinandy
2024-10-11 20:56 ` Kristoffer Haugsbakk
2024-10-11 21:04 ` Bence Ferdinandy
2024-10-11 21:28 ` Junio C Hamano
2024-10-12 19:41 ` Bence Ferdinandy
2024-10-13 9:34 ` Phillip Wood
2024-10-13 10:07 ` Kristoffer Haugsbakk
2024-10-13 12:09 ` karthik nayak
2024-10-13 15:39 ` Kristoffer Haugsbakk
2024-10-13 20:40 ` Bence Ferdinandy
2024-10-14 15:06 ` Kristoffer Haugsbakk
2024-10-15 19:03 ` [PATCH 0/6] doc: update-ref: amend old material and discuss symrefs kristofferhaugsbakk
2024-10-15 19:03 ` [PATCH 1/6] doc: update-ref: drop “flag” kristofferhaugsbakk
2024-10-16 20:45 ` Taylor Blau
2024-10-16 22:08 ` Eric Sunshine
2024-10-16 22:09 ` Taylor Blau
2024-10-17 15:30 ` Kristoffer Haugsbakk
2024-10-17 16:31 ` Eric Sunshine
2024-10-17 18:50 ` Taylor Blau
2024-10-15 19:03 ` [PATCH 2/6] doc: update-ref: remove safety paragraphs kristofferhaugsbakk
2024-10-16 20:47 ` Taylor Blau
2024-10-15 19:03 ` [PATCH 3/6] doc: update-ref: demote symlink to last section kristofferhaugsbakk
2024-10-15 19:03 ` [PATCH 4/6] doc: update-ref: remove confusing paragraph kristofferhaugsbakk
2024-10-16 20:51 ` Taylor Blau [this message]
2024-10-16 20:55 ` Kristoffer Haugsbakk
2024-10-16 20:57 ` Taylor Blau
2024-10-15 19:03 ` [PATCH 5/6] doc: update-ref: discuss symbolic links kristofferhaugsbakk
2024-10-15 19:08 ` Kristoffer Haugsbakk
2024-10-16 20:52 ` Taylor Blau
2024-10-15 19:03 ` [PATCH 6/6] doc: mutually link update-ref and symbolic-ref kristofferhaugsbakk
2024-10-16 8:51 ` [PATCH 0/6] doc: update-ref: amend old material and discuss symrefs Bence Ferdinandy
2024-10-16 20:54 ` Taylor Blau
2024-10-16 21:00 ` Kristoffer Haugsbakk
2024-10-19 19:59 ` [PATCH v2 " kristofferhaugsbakk
2024-10-19 19:59 ` [PATCH v2 1/6] Documentation/git-update-ref.txt: drop “flag” kristofferhaugsbakk
2024-10-20 11:09 ` karthik nayak
2024-10-19 19:59 ` [PATCH v2 2/6] Documentation/git-update-ref.txt: remove safety paragraphs kristofferhaugsbakk
2024-10-20 11:13 ` karthik nayak
2024-10-20 12:30 ` Kristoffer Haugsbakk
2024-10-20 16:24 ` Kristoffer Haugsbakk
2024-10-19 19:59 ` [PATCH v2 3/6] Documentation/git-update-ref.txt: demote symlink to last section kristofferhaugsbakk
2024-10-19 19:59 ` [PATCH v2 4/6] Documentation/git-update-ref.txt: remove confusing paragraph kristofferhaugsbakk
2024-10-19 19:59 ` [PATCH v2 5/6] Documentation/git-update-ref.txt: discuss symbolic refs kristofferhaugsbakk
2024-10-19 19:59 ` [PATCH v2 6/6] Documentation: mutually link update-ref and symbolic-ref kristofferhaugsbakk
2024-10-20 11:16 ` [PATCH v2 0/6] doc: update-ref: amend old material and discuss symrefs karthik nayak
2024-10-21 20:47 ` [PATCH v3 " kristofferhaugsbakk
2024-10-21 20:47 ` [PATCH v3 1/6] Documentation/git-update-ref.txt: drop “flag” kristofferhaugsbakk
2024-10-21 20:47 ` [PATCH v3 2/6] Documentation/git-update-ref.txt: remove safety paragraphs kristofferhaugsbakk
2024-10-21 20:47 ` [PATCH v3 3/6] Documentation/git-update-ref.txt: demote symlink to last section kristofferhaugsbakk
2024-10-21 20:47 ` [PATCH v3 4/6] Documentation/git-update-ref.txt: remove confusing paragraph kristofferhaugsbakk
2024-10-21 20:47 ` [PATCH v3 5/6] Documentation/git-update-ref.txt: discuss symbolic refs kristofferhaugsbakk
2024-10-21 20:47 ` [PATCH v3 6/6] Documentation: mutually link update-ref and symbolic-ref kristofferhaugsbakk
2024-10-21 20:50 ` [PATCH v3 0/6] doc: update-ref: amend old material and discuss symrefs Taylor Blau
2024-10-12 6:25 ` ref: with git update-ref? Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxAnO5zH1vtgRvLk@nand.local \
--to=me@ttaylorr.com \
--cc=bence@ferdinandy.com \
--cc=code@khaugsbakk.name \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=karthik.188@gmail.com \
--cc=kristofferhaugsbakk@fastmail.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).