git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Jeff King <peff@peff.net>
Cc: Taylor Blau <me@ttaylorr.com>,
	git@vger.kernel.org, Adam Dinwoodie <adam@dinwoodie.org>
Subject: Re: [PATCH] builtin/credential-cache--daemon: fix error when "exit"ing on Cygwin
Date: Thu, 17 Oct 2024 10:46:07 +0200	[thread overview]
Message-ID: <ZxDOydD7kpSGchiQ@pks.im> (raw)
In-Reply-To: <20241017023319.GA1858436@coredump.intra.peff.net>

On Wed, Oct 16, 2024 at 10:33:19PM -0400, Jeff King wrote:
> On Wed, Oct 16, 2024 at 04:28:49PM -0400, Taylor Blau wrote:
> 
> > > This all seemed eerily familiar. Try this thread:
> > >
> > >   https://lore.kernel.org/git/9dc3e85f-a532-6cff-de11-1dfb2e4bc6b6@ramsayjones.plus.com/
> > >
> > > It looks like the conclusion was that we should adjust errno handling on
> > > the client side, but nobody ever followed up with an actual patch.
> > 
> > Thanks for digging. It would be great if you both and Ramsay could unify
> > on an agreeable path forward here.
> 
> I think the patch Ramsay posted elsewhere is the right way forward.
> Hopefully he can fill out a commit message with the summary and then we
> can proceed.
> 
> (I'm happy to help with explaining the credential-cache side, but I
> would just be hand-waving on the cygwin parts).

Sounds great to me -- in that case, let's just drop my patch. I was
basically just trying to get somebody to have a look at the issue, and
it very much seems like I succeeded :)

Ramsay, do you want to polish your patch with a commit message or shall
I pick it up and iterate on it?

Thanks all for chiming in!

Patrick

  reply	other threads:[~2024-10-17  8:46 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-16 14:21 [PATCH] builtin/credential-cache--daemon: fix error when "exit"ing on Cygwin Patrick Steinhardt
2024-10-16 14:55 ` Jeff King
2024-10-16 15:09   ` Jeff King
2024-10-16 15:39     ` Ramsay Jones
2024-10-16 20:28     ` Taylor Blau
2024-10-17  2:33       ` Jeff King
2024-10-17  8:46         ` Patrick Steinhardt [this message]
2024-10-17 22:58           ` Ramsay Jones
2024-10-18  4:36             ` Patrick Steinhardt
2024-10-17 20:54         ` Taylor Blau
2024-10-16 15:12 ` Ramsay Jones
2024-10-18  4:36 ` [PATCH v2] " Patrick Steinhardt
2024-10-18  5:29   ` [PATCH] credential-cache: treat ECONNABORTED like ECONNRESET Jeff King
2024-10-18  5:32     ` Patrick Steinhardt
2024-10-18 15:33     ` Ramsay Jones
2024-10-18 21:17       ` Taylor Blau
2024-10-18 21:27     ` Kristoffer Haugsbakk
2024-10-19 21:21       ` Jeff King
2024-10-20 17:08         ` Comment trailers vs. bracketed lines Kristoffer Haugsbakk
2025-05-07 16:41           ` Kristoffer Haugsbakk
2025-05-08 20:24             ` Jeff King
2025-05-07 19:20           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZxDOydD7kpSGchiQ@pks.im \
    --to=ps@pks.im \
    --cc=adam@dinwoodie.org \
    --cc=git@vger.kernel.org \
    --cc=me@ttaylorr.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).