git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: clar unit testing framework FTBFS on uclibc systems (wchar_t unsupported)
Date: Thu, 17 Oct 2024 15:33:51 +0200	[thread overview]
Message-ID: <ZxESP0xHV4cK64i0@pks.im> (raw)
In-Reply-To: <ZxCJqe4-rsRo1yHg@archie.me>

On Thu, Oct 17, 2024 at 10:51:05AM +0700, Bagas Sanjaya wrote:
> Hi,
> 
> Since clar unit testing framework was imported by commit 9b7caa2809cb (t:
> import the clar unit testing framework, 2024-09-04), Git FTBFS on uclibc
> systems built by Buildroot:

Wait a second, that doesn't sound right to me. `wchar_t` is part of ISO
C90, so any system not supporting it would basically be unsupported by
us from my point of view. And indeed, uclibc _does_ support that type
alright. I guess the issue is rather that we're relying on some kind of
platform-specific behaviour and thus don't include the correct header.

I'll have a look, thanks for the report!

Patrick

  reply	other threads:[~2024-10-17 13:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-17  3:51 clar unit testing framework FTBFS on uclibc systems (wchar_t unsupported) Bagas Sanjaya
2024-10-17 13:33 ` Patrick Steinhardt [this message]
2024-10-17 13:54   ` Patrick Steinhardt
2024-10-17 20:08     ` Taylor Blau
2024-10-17 22:21     ` brian m. carlson
2024-10-18  4:51       ` Jeff King
2024-10-18  4:59         ` Patrick Steinhardt
2024-10-18  5:24           ` Jeff King
2024-10-18  5:31             ` Patrick Steinhardt
2024-10-18 20:50               ` Taylor Blau
2024-10-21  6:44                 ` Patrick Steinhardt
2024-10-21 19:30                   ` Jeff King
2024-10-21 19:41                     ` Taylor Blau
2024-10-18 20:07         ` brian m. carlson
2024-10-21 19:19           ` Jeff King
2024-10-21 19:31             ` Jeff King
2024-10-18 13:49     ` Bagas Sanjaya
2024-10-21  6:44       ` Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZxESP0xHV4cK64i0@pks.im \
    --to=ps@pks.im \
    --cc=bagasdotme@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).