Re: [PATCH] builtin/credential-cache--daemon: fix error when "exit"ing on Cygwin

[Patrick Steinhardt <ps@pks.im>]

On Thu, Oct 17, 2024 at 11:58:33PM +0100, Ramsay Jones wrote:
> 
> 
> On 17/10/2024 09:46, Patrick Steinhardt wrote:
> > On Wed, Oct 16, 2024 at 10:33:19PM -0400, Jeff King wrote:
> >> On Wed, Oct 16, 2024 at 04:28:49PM -0400, Taylor Blau wrote:
> >>
> >>>> This all seemed eerily familiar. Try this thread:
> >>>>
> >>>>   https://lore.kernel.org/git/9dc3e85f-a532-6cff-de11-1dfb2e4bc6b6@ramsayjones.plus.com/
> >>>>
> >>>> It looks like the conclusion was that we should adjust errno handling on
> >>>> the client side, but nobody ever followed up with an actual patch.
> >>>
> >>> Thanks for digging. It would be great if you both and Ramsay could unify
> >>> on an agreeable path forward here.
> >>
> >> I think the patch Ramsay posted elsewhere is the right way forward.
> >> Hopefully he can fill out a commit message with the summary and then we
> >> can proceed.
> >>
> >> (I'm happy to help with explaining the credential-cache side, but I
> >> would just be hand-waving on the cygwin parts).
> > 
> > Sounds great to me -- in that case, let's just drop my patch. I was
> > basically just trying to get somebody to have a look at the issue, and
> > it very much seems like I succeeded :)
> > 
> > Ramsay, do you want to polish your patch with a commit message or shall
> > I pick it up and iterate on it?
> 
> I can't get to it before the weekend, at the earliest, sorry! :(
> 
> If you fancy picking it up, please be my guest! :)

I've sent v2 using that hack now, noting your original authorship. I
want to finally get on top of all of those platform-specific failures :)

Thanks!

Patrick