From: Patrick Steinhardt <ps@pks.im>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Adam Dinwoodie <adam@dinwoodie.org>,
Ramsay Jones <ramsay@ramsayjones.plus.com>,
Taylor Blau <me@ttaylorr.com>
Subject: Re: [PATCH] credential-cache: treat ECONNABORTED like ECONNRESET
Date: Fri, 18 Oct 2024 07:32:21 +0200 [thread overview]
Message-ID: <ZxHy5Q-0KJ0q7c6m@pks.im> (raw)
In-Reply-To: <20241018052952.GE2408674@coredump.intra.peff.net>
On Fri, Oct 18, 2024 at 01:29:52AM -0400, Jeff King wrote:
> On Fri, Oct 18, 2024 at 06:36:11AM +0200, Patrick Steinhardt wrote:
>
> > Subject: builtin/credential-cache--daemon: fix error when "exit"ing on Cygwin
>
> I think this commit message has a few unclear or inaccurate bits,
> because it's based on the earlier attempt. E.g., the change is now on
> the client side, not in credential-cache--daemon.
>
> And I think rather than say "the daemon exit rules are intricate", we
> can actually outline the rules. :)
>
> So here's what I had written after reading through the old thread. It
> would preferably get Ramsay's Signed-off-by before being applied.
Works for me. I don't really care whose patch lands, I just want the
issue to be fixed :) Thanks!
Patrick
next prev parent reply other threads:[~2024-10-18 5:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 14:21 [PATCH] builtin/credential-cache--daemon: fix error when "exit"ing on Cygwin Patrick Steinhardt
2024-10-16 14:55 ` Jeff King
2024-10-16 15:09 ` Jeff King
2024-10-16 15:39 ` Ramsay Jones
2024-10-16 20:28 ` Taylor Blau
2024-10-17 2:33 ` Jeff King
2024-10-17 8:46 ` Patrick Steinhardt
2024-10-17 22:58 ` Ramsay Jones
2024-10-18 4:36 ` Patrick Steinhardt
2024-10-17 20:54 ` Taylor Blau
2024-10-16 15:12 ` Ramsay Jones
2024-10-18 4:36 ` [PATCH v2] " Patrick Steinhardt
2024-10-18 5:29 ` [PATCH] credential-cache: treat ECONNABORTED like ECONNRESET Jeff King
2024-10-18 5:32 ` Patrick Steinhardt [this message]
2024-10-18 15:33 ` Ramsay Jones
2024-10-18 21:17 ` Taylor Blau
2024-10-18 21:27 ` Kristoffer Haugsbakk
2024-10-19 21:21 ` Jeff King
2024-10-20 17:08 ` Comment trailers vs. bracketed lines Kristoffer Haugsbakk
2025-05-07 16:41 ` Kristoffer Haugsbakk
2025-05-08 20:24 ` Jeff King
2025-05-07 19:20 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxHy5Q-0KJ0q7c6m@pks.im \
--to=ps@pks.im \
--cc=adam@dinwoodie.org \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).