From: Taylor Blau <me@ttaylorr.com>
To: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Cc: Seyi Kuforiji <kuforiji98@gmail.com>,
git@vger.kernel.org, Patrick Steinhardt <ps@pks.im>,
Phillip Wood <phillip.wood@dunelm.org.uk>
Subject: Re: [[PATCH][Outreachy]] t7011-skip-worktree-reading.sh: ensure no whitespace after redirect operators
Date: Fri, 18 Oct 2024 17:03:03 -0400 [thread overview]
Message-ID: <ZxLNBxcnTf8nsT1H@nand.local> (raw)
In-Reply-To: <b005084c-2710-4567-9217-27f34c2bbc95@app.fastmail.com>
On Fri, Oct 18, 2024 at 10:04:43PM +0200, Kristoffer Haugsbakk wrote:
> Hiya
>
> > [[PATCH][Outreachy]]
>
> Apparently you can’t nest brackets like this according to git-am(1). I
> got this:
>
> ] t7011-skip-worktree-reading.sh: ensure no whitespace after redirect operators
>
> Doesn’t really matter though. I suspect `[PATCH Outreachy]` would work.
Indeed. With format-patch, you can do '--rfc=-Outreachy' to achieve the
desired effect.
> The diff here is clean. It only does what you describe in the commit
> message. Good.
>
> I checked the file and I can’t find any missed instances. Nice!
Thanks for the helpful review and feedback for Seyi's patch.
Seyi: I'll queue this into my tree, but mark it as expecting a new
version to address Kristoffer's comments above. Thanks.
Thanks,
Taylor
next prev parent reply other threads:[~2024-10-18 21:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 19:17 [[PATCH][Outreachy]] t7011-skip-worktree-reading.sh: ensure no whitespace after redirect operators Seyi Kuforiji
2024-10-18 20:04 ` Kristoffer Haugsbakk
2024-10-18 21:03 ` Taylor Blau [this message]
2024-10-19 8:42 ` Seyi Chamber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxLNBxcnTf8nsT1H@nand.local \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=kristofferhaugsbakk@fastmail.com \
--cc=kuforiji98@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).