From: Patrick Steinhardt <ps@pks.im>
To: Toon Claes <toon@iotcl.com>
Cc: git@vger.kernel.org, Taylor Blau <me@ttaylorr.com>,
Jeff King <peff@peff.net>
Subject: Re: [PATCH v2] ref-filter: format iteratively with lexicographic refname sorting
Date: Mon, 21 Oct 2024 13:33:50 +0200 [thread overview]
Message-ID: <ZxY7_mNriWFzaDQr@pks.im> (raw)
In-Reply-To: <87ttd5btjf.fsf@iotcl.com>
On Mon, Oct 21, 2024 at 01:10:44PM +0200, Toon Claes wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> > @@ -3258,7 +3279,6 @@ static inline int can_do_iterative_format(struct ref_filter *filter,
> > */
> > return !(filter->reachable_from ||
> > filter->unreachable_from ||
> > - sorting ||
>
> Just a small nit, because we remove `sorting` from this condition, I
> suggest to also remove the following comment above it:
>
> * - sorting the filtered results
>
>
> Otherwise no comments from my side.
Ah, true. Will fix in v3, thanks!
Patrick
next prev parent reply other threads:[~2024-10-21 11:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 6:00 [PATCH] ref-filter: format iteratively with lexicographic refname sorting Patrick Steinhardt
2024-10-16 22:11 ` Taylor Blau
2024-10-17 2:48 ` Jeff King
2024-10-17 4:28 ` Patrick Steinhardt
2024-10-21 12:36 ` karthik nayak
2024-10-21 20:45 ` Taylor Blau
2024-10-17 5:09 ` [PATCH v2] " Patrick Steinhardt
2024-10-17 20:57 ` Taylor Blau
2024-10-21 11:10 ` Toon Claes
2024-10-21 11:33 ` Patrick Steinhardt [this message]
2024-10-21 11:33 ` [PATCH v3] " Patrick Steinhardt
2024-10-21 20:46 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxY7_mNriWFzaDQr@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
--cc=toon@iotcl.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).