From: Patrick Steinhardt <ps@pks.im>
To: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Cc: Seyi Kuforiji <kuforiji98@gmail.com>,
git@vger.kernel.org, Phillip Wood <phillip.wood@dunelm.org.uk>,
Taylor Blau <me@ttaylorr.com>
Subject: Re: [PATCH v2 Outreachy] t7011: ensure no whitespace after redirect
Date: Mon, 21 Oct 2024 14:03:35 +0200 [thread overview]
Message-ID: <ZxZDFyKxTn_D7c3o@pks.im> (raw)
In-Reply-To: <cb88194a-15d2-4c3d-8768-189853572ac0@app.fastmail.com>
On Sat, Oct 19, 2024 at 07:54:30PM +0200, Kristoffer Haugsbakk wrote:
> On Sat, Oct 19, 2024, at 18:34, Seyi Kuforiji wrote:
> > This change updates the script to conform to the coding standards
> > outlined in the Git project's documentation. According to the guidelines
> > in Documentation/CodingGuidelines under "Redirection operators", there
> > should be no whitespace after redirection operators.
> >
> > Signed-off-by: Seyi Kuforiji <kuforiji98@gmail.com>
> > ---
> > t/t7011-skip-worktree-reading.sh | 22 +++++++++++-----------
> > 1 file changed, 11 insertions(+), 11 deletions(-)
>
> I can confirm that there are no changes in this version to the patch
> itself. Which was expected since the change was good.
>
> The difference in this version is that the commit message has been
> improved. At least according to my taste.
Agreed, this patch looks good to me, too. Thanks!
Patrick
next prev parent reply other threads:[~2024-10-21 12:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-19 16:34 [PATCH v2 Outreachy] t7011: ensure no whitespace after redirect Seyi Kuforiji
2024-10-19 17:54 ` Kristoffer Haugsbakk
2024-10-21 12:03 ` Patrick Steinhardt [this message]
2024-10-21 17:17 ` Seyi Chamber
2024-10-21 19:58 ` Taylor Blau
2024-10-22 17:11 ` Seyi Chamber
2024-10-23 5:00 ` Patrick Steinhardt
2024-10-23 7:24 ` Seyi Chamber
2024-10-23 9:55 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxZDFyKxTn_D7c3o@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=kristofferhaugsbakk@fastmail.com \
--cc=kuforiji98@gmail.com \
--cc=me@ttaylorr.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).