From: Taylor Blau <me@ttaylorr.com>
To: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Cc: Patrick Steinhardt <ps@pks.im>,
Sven Strickroth <email@cs-ware.de>,
git@vger.kernel.org
Subject: Re: [PATCH] Fix duplicate word typos
Date: Mon, 21 Oct 2024 16:04:28 -0400 [thread overview]
Message-ID: <ZxazzIUA/JQDi/Uw@nand.local> (raw)
In-Reply-To: <89ee8fab-ac1e-4e9b-98b7-f2ad25e8f0d0@app.fastmail.com>
On Mon, Oct 21, 2024 at 11:57:25AM +0200, Kristoffer Haugsbakk wrote:
> On Mon, Oct 21, 2024, at 11:47, Patrick Steinhardt wrote:
> > On Sat, Oct 19, 2024 at 12:06:54PM +0200, Kristoffer Haugsbakk wrote:
> >> Hi
> >>
> >> I guess it was an intentional choice to not use an “area” in the commit
> >> message?
> >>
> >> I found this similar patch which used `*` as the area: abcb66c614c (*:
> >> fix typos which duplicate a word, 2021-06-11); review here:
> >>
> >> https://lore.kernel.org/git/CAPig+cTjjNrU9q8UPm+CRuTKq8_XNc+1z7-3F4bvetBi+NjKeQ@mail.gmail.com/
> >
> > I think many projects also use the "global:" prefix to denote changes
> > all over the place. We also do this in Git, even though I should
> > probably say that all patches that do have that prefix are from myself
> > :P In any case, I don't have a strong opinion here.
> >
> > Patrick
>
> I forgot to mention that “treewide” is used to a decent degree. :)
Yes, I think in any case we can blame Patrick for setting the convention
here ;-).
(For what it's worth, I have occasionally used '*:' in the past, but I
don't think it matters so long as we use something to avoid 99.9% of
commits being prefixed with an area and having a few odd ones stuck
out).
Thanks,
Taylor
next prev parent reply other threads:[~2024-10-21 20:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-19 10:37 [PATCH] Fix duplicate word typos Sven Strickroth
2024-10-19 10:06 ` Kristoffer Haugsbakk
2024-10-21 9:47 ` Patrick Steinhardt
2024-10-21 9:57 ` Kristoffer Haugsbakk
2024-10-21 15:12 ` [PATCH v2] global: " Sven Strickroth
2024-10-22 5:07 ` Patrick Steinhardt
2024-10-21 20:04 ` Taylor Blau [this message]
2024-10-21 20:05 ` [PATCH] " Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxazzIUA/JQDi/Uw@nand.local \
--to=me@ttaylorr.com \
--cc=email@cs-ware.de \
--cc=git@vger.kernel.org \
--cc=kristofferhaugsbakk@fastmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).