* [PATCH] SubmittingPatches: tags -> trailers
@ 2024-10-20 16:57 kristofferhaugsbakk
2024-10-20 21:29 ` Josh Soref
0 siblings, 1 reply; 3+ messages in thread
From: kristofferhaugsbakk @ 2024-10-20 16:57 UTC (permalink / raw)
To: git; +Cc: Kristoffer Haugsbakk, Josh Soref
From: Kristoffer Haugsbakk <code@khaugsbakk.name>
“Trailer” is the preferred nomenclature in this project. Also add a
definite article where I think it makes sense.
As we can see the rest of the document already prefers this term. This
just gets rid of the last stragglers.
Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name>
---
Notes (series):
Commit message:
“ “Trailer” is the preferred nomenclature in this project.
Must surely be true since git-interpret-trailers(1) does not even
contain the string “tag”.
I did a grep in this directory:
git grep tags ':(exclude)RelNotes'
It didn’t look like there were any other mentions of “tags” in this
sense. Of course it was difficult to look through.
+CC: Josh Soref <jsoref@gmail.com> based on
e.g. ac9fff2bf1c (SubmittingPatches: discourage new trailers,
2023-12-28)
Documentation/SubmittingPatches | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index d8a8caa7916..db17bc7fe2c 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -412,13 +412,13 @@ Also notice that a real name is used in the `Signed-off-by` trailer. Please
don't hide your real name.
[[commit-trailers]]
-If you like, you can put extra tags at the end:
+If you like, you can put extra trailers at the end:
. `Reported-by:` is used to credit someone who found the bug that
the patch attempts to fix.
. `Acked-by:` says that the person who is more familiar with the area
the patch attempts to modify liked the patch.
-. `Reviewed-by:`, unlike the other tags, can only be offered by the
+. `Reviewed-by:`, unlike the other trailers, can only be offered by the
reviewers themselves when they are completely satisfied with the
patch after a detailed analysis.
. `Tested-by:` is used to indicate that the person applied the patch
@@ -436,7 +436,7 @@ While you can also create your own trailer if the situation warrants it, we
encourage you to instead use one of the common trailers in this project
highlighted above.
-Only capitalize the very first letter of tags, i.e. favor
+Only capitalize the very first letter of the trailer, i.e. favor
"Signed-off-by" over "Signed-Off-By" and "Acked-by:" over "Acked-By".
[[git-tools]]
base-commit: 34b6ce9b30747131b6e781ff718a45328aa887d0
--
2.46.1.641.g54e7913fcb6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] SubmittingPatches: tags -> trailers
2024-10-20 16:57 [PATCH] SubmittingPatches: tags -> trailers kristofferhaugsbakk
@ 2024-10-20 21:29 ` Josh Soref
2024-10-21 21:22 ` Taylor Blau
0 siblings, 1 reply; 3+ messages in thread
From: Josh Soref @ 2024-10-20 21:29 UTC (permalink / raw)
To: kristofferhaugsbakk; +Cc: git, Kristoffer Haugsbakk
Kristoffer Haugsbakk wrote:
> “Trailer” is the preferred nomenclature in this project. Also add a
> definite article where I think it makes sense.
>
> As we can see the rest of the document already prefers this term. This
> just gets rid of the last stragglers.
>
> Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name>
> ---
>
> Notes (series):
> Commit message:
>
> “ “Trailer” is the preferred nomenclature in this project.
>
> Must surely be true since git-interpret-trailers(1) does not even
> contain the string “tag”.
>
> I did a grep in this directory:
>
> git grep tags ':(exclude)RelNotes'
>
> It didn’t look like there were any other mentions of “tags” in this
> sense. Of course it was difficult to look through.
>
> +CC: Josh Soref <jsoref@gmail.com> based on
> e.g. ac9fff2bf1c (SubmittingPatches: discourage new trailers,
> 2023-12-28)
This change makes sense to me.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] SubmittingPatches: tags -> trailers
2024-10-20 21:29 ` Josh Soref
@ 2024-10-21 21:22 ` Taylor Blau
0 siblings, 0 replies; 3+ messages in thread
From: Taylor Blau @ 2024-10-21 21:22 UTC (permalink / raw)
To: Josh Soref; +Cc: kristofferhaugsbakk, git, Kristoffer Haugsbakk
On Sun, Oct 20, 2024 at 05:29:14PM -0400, Josh Soref wrote:
> Kristoffer Haugsbakk wrote:
> > “Trailer” is the preferred nomenclature in this project. Also add a
> > definite article where I think it makes sense.
> >
> > As we can see the rest of the document already prefers this term. This
> > just gets rid of the last stragglers.
> >
> > Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name>
> > ---
> >
> > Notes (series):
> > Commit message:
> >
> > “ “Trailer” is the preferred nomenclature in this project.
> >
> > Must surely be true since git-interpret-trailers(1) does not even
> > contain the string “tag”.
> >
> > I did a grep in this directory:
> >
> > git grep tags ':(exclude)RelNotes'
> >
> > It didn’t look like there were any other mentions of “tags” in this
> > sense. Of course it was difficult to look through.
> >
> > +CC: Josh Soref <jsoref@gmail.com> based on
> > e.g. ac9fff2bf1c (SubmittingPatches: discourage new trailers,
> > 2023-12-28)
>
> This change makes sense to me.
To me as well. Thanks, both. Will queue.
Thanks,
Taylor
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-21 21:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-20 16:57 [PATCH] SubmittingPatches: tags -> trailers kristofferhaugsbakk
2024-10-20 21:29 ` Josh Soref
2024-10-21 21:22 ` Taylor Blau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).