From: Taylor Blau <me@ttaylorr.com>
To: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Cc: Andrew Kreimer <algonell@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] t1016: clean up style
Date: Mon, 21 Oct 2024 17:48:05 -0400 [thread overview]
Message-ID: <ZxbMFQSL1brz86f+@nand.local> (raw)
In-Reply-To: <ZxbLlA0xbuhP7DJK@nand.local>
On Mon, Oct 21, 2024 at 05:45:56PM -0400, Taylor Blau wrote:
> On Sun, Oct 20, 2024 at 02:46:18PM +0200, Kristoffer Haugsbakk wrote:
> > Hi
> >
> > On Sun, Oct 20, 2024, at 14:17, Andrew Kreimer wrote:
> > > Use `test_config`.
> > >
> > > Remove whitespace after redirect operator.
> > >
> > > Reported-by: Taylor Blau <me@ttaylorr.com>
> > > Signed-off-by: Andrew Kreimer <algonell@gmail.com>
> > > ---
> > > As discussed in:
> > > - https://lore.kernel.org/git/ZxFyKXDCJkRZYYQY@nand.local/
> > > […]
> > > - git config gpg.program $TEST_DIRECTORY/t1016/gpg &&
> > > - echo "Hellow World!" > hello &&
> > > + test_config gpg.program $TEST_DIRECTORY/t1016/gpg &&
> > > + echo "Hellow World!" >hello &&
> >
> > What Taylor wrote:
> >
> > > Thanks, both. [Andrew] -- it's fine to do this in the same, or a
> > > separate patch in the new round. Thanks.
> >
> > You’ve posted a new, standalone patch. But what Taylor asked for was a
> > new round on that typo patch where you either squash these changes into
> > the original patch or have the typo patch plus this one.
> >
> > At least that’s how I understand it.
>
> I said originally that either was fine, but then revised my statement
> after remembering that the original topic was already in 'next', so any
> further changes would have to be done on top.
...but after queueing, this patch does not apply cleanly on ak/typofix,
which is what this patch should be based on AFAICT.
Andrew, would you please send a version based on the aforementioned
topic?
Thanks,
Taylor
next prev parent reply other threads:[~2024-10-21 21:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-20 12:17 [PATCH] t1016: clean up style Andrew Kreimer
2024-10-20 12:46 ` Kristoffer Haugsbakk
2024-10-21 21:45 ` Taylor Blau
2024-10-21 21:48 ` Taylor Blau [this message]
2024-10-22 10:29 ` Andrew Kreimer
-- strict thread matches above, loose matches on Subject: below --
2024-11-02 16:53 Andrew Kreimer
2024-11-02 19:11 ` Kristoffer Haugsbakk
2024-11-03 2:42 ` Junio C Hamano
2024-11-03 13:49 ` Andrew Kreimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxbMFQSL1brz86f+@nand.local \
--to=me@ttaylorr.com \
--cc=algonell@gmail.com \
--cc=git@vger.kernel.org \
--cc=kristofferhaugsbakk@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).