git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: David Gstir <david@sigma-star.at>,
	git@vger.kernel.org, Richard Weinberger <richard@sigma-star.at>,
	Jeff King <peff@peff.net>
Subject: Re: [PATCH] grep: disable lookahead on error
Date: Mon, 21 Oct 2024 17:57:21 -0400	[thread overview]
Message-ID: <ZxbOQXNn7Y5v2MPB@nand.local> (raw)
In-Reply-To: <7a51a68e-5f9d-4444-a568-9ca180bc4c6b@web.de>

On Sun, Oct 20, 2024 at 01:02:32PM +0200, René Scharfe wrote:
> ---
>  grep.c          | 30 ++++++++++++++++++++----------
>  t/t7810-grep.sh |  9 +++++++++
>  2 files changed, 29 insertions(+), 10 deletions(-)

Thanks, René. The patch looks good to me, but it would be nice to hear
from David who could confirm that it fixes the issue on his end as well.

Thanks,
Taylor

  reply	other threads:[~2024-10-21 21:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-14 13:34 git grep does not find all occurrences on macOS David Gstir
2024-10-15  0:26 ` Taylor Blau
2024-10-15 20:15   ` René Scharfe
2024-10-20 11:02     ` [PATCH] grep: disable lookahead on error René Scharfe
2024-10-21 21:57       ` Taylor Blau [this message]
2024-10-22  5:58       ` David Gstir

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZxbOQXNn7Y5v2MPB@nand.local \
    --to=me@ttaylorr.com \
    --cc=david@sigma-star.at \
    --cc=git@vger.kernel.org \
    --cc=l.s.r@web.de \
    --cc=peff@peff.net \
    --cc=richard@sigma-star.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).