git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Sven Strickroth <email@cs-ware.de>
Cc: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>,
	git@vger.kernel.org
Subject: Re: [PATCH v2] global: Fix duplicate word typos
Date: Tue, 22 Oct 2024 07:07:01 +0200	[thread overview]
Message-ID: <Zxcy9W0DXnaCR9FJ@pks.im> (raw)
In-Reply-To: <6ce47185-690d-415e-95c9-06a3b828be29e@cs-ware.de>

On Mon, Oct 21, 2024 at 05:12:26PM +0200, Sven Strickroth wrote:
> Used regex to find these typos:
> 
>     (?<!struct )(?<=\s)([a-z]{1,}) \1(?=\s)

One more nit: the first word after the area should be lower-case. So the
subject should be "foo: something" rather than "foo: Something". Other
than that the patch looks good to me. I don't really think that this is
worth a reroll, but others may disagree with that.

> diff --git a/ci/lib.sh b/ci/lib.sh
> index 74b430be23..bfa1fe370b 100755
> --- a/ci/lib.sh
> +++ b/ci/lib.sh
> @@ -62,7 +62,7 @@ trap "end_group 'CI setup'" EXIT
>  # something went wrong.
>  #
>  # We already enabled tracing executed commands earlier. This helps by showing
> -# how # environment variables are set and and dependencies are installed.
> +# how # environment variables are set and dependencies are installed.
>  set -e
>  
>  skip_branch_tip_with_tag () {

This one has a stray "#" in it, but it's perfectly fine to not fix this
as part of this commit.

Thanks!

Patrick

  reply	other threads:[~2024-10-22  5:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-19 10:37 [PATCH] Fix duplicate word typos Sven Strickroth
2024-10-19 10:06 ` Kristoffer Haugsbakk
2024-10-21  9:47   ` Patrick Steinhardt
2024-10-21  9:57     ` Kristoffer Haugsbakk
2024-10-21 15:12       ` [PATCH v2] global: " Sven Strickroth
2024-10-22  5:07         ` Patrick Steinhardt [this message]
2024-10-21 20:04       ` [PATCH] " Taylor Blau
2024-10-21 20:05   ` Taylor Blau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zxcy9W0DXnaCR9FJ@pks.im \
    --to=ps@pks.im \
    --cc=email@cs-ware.de \
    --cc=git@vger.kernel.org \
    --cc=kristofferhaugsbakk@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).