git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Jeff King <peff@peff.net>
Cc: fox <fox.gbr@townlong-yak.com>,
	Eric Sunshine <sunshine@sunshineco.com>,
	git@vger.kernel.org
Subject: Re: Bug report: v2.47.0 cannot fetch version 1 pack indexes
Date: Tue, 22 Oct 2024 11:50:27 -0400	[thread overview]
Message-ID: <ZxfJw1Ju8WBDktj1@nand.local> (raw)
In-Reply-To: <20241022050040.GA1247135@coredump.intra.peff.net>

On Tue, Oct 22, 2024 at 01:00:40AM -0400, Jeff King wrote:
> So...what does it all mean for this fix?
>
> I think the patch I posted earlier, to keep the .idx files as separate
> tempfiles, is only slightly worse than the status quo (it doesn't keep
> P.idx that we didn't need). And given my general feelings towards the
> dumb-http protocol, maybe that is the right place to stop.
>
> It just feels like we _could_ be improving things with a better managed
> .idx cache system. And that would fix the regression at the same time.
> But I'm not sure it's worth sinking time and complexity into this
> terribly inefficient protocol.
>
> (Part of why I laid all this out is that until wrote all of the above, I
> wasn't completely convinced that case (a) was the only one that
> suffered, and that it was so mild).

All very well analyzed. I share your feelings about the dumb-HTTP
protocol. It would be nice to fix, but I have a feeling that our
collective time is probably better spent pursuing a reasonable band-aid
and then focusing our attention elsewhere ;-).

Thanks,
Taylor

      reply	other threads:[~2024-10-22 15:50 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-19 23:22 Bug report: v2.47.0 cannot fetch version 1 pack indexes fox
2024-10-20  0:37 ` Eric Sunshine
2024-10-21 20:06   ` Taylor Blau
2024-10-20  1:24 ` Jeff King
2024-10-20  2:40   ` Jeff King
2024-10-21 20:33     ` Taylor Blau
2024-10-22  5:14       ` Jeff King
2024-10-22 15:18         ` Taylor Blau
2024-10-25  6:41         ` [PATCH 0/11] dumb-http pack index v1 regression + cleanups Jeff King
2024-10-25  6:43           ` [PATCH 01/11] midx: avoid duplicate packed_git entries Jeff King
2024-10-25 21:09             ` Taylor Blau
2024-10-25  6:44           ` [PATCH 02/11] t5550: count fetches in "previously-fetched .idx" test Jeff King
2024-10-25  6:58           ` [PATCH 03/11] dumb-http: store downloaded pack idx as tempfile Jeff King
2024-10-25 21:18             ` Taylor Blau
2024-10-26  6:02               ` Jeff King
2024-10-28  0:14                 ` Taylor Blau
2024-10-25  7:00           ` [PATCH 04/11] packfile: drop has_pack_index() Jeff King
2024-10-25 21:27             ` Taylor Blau
2024-10-25  7:00           ` [PATCH 05/11] packfile: drop sha1_pack_name() Jeff King
2024-10-25  7:01           ` [PATCH 06/11] packfile: drop sha1_pack_index_name() Jeff King
2024-10-25  7:02           ` [PATCH 07/11] packfile: warn people away from parse_packed_git() Jeff King
2024-10-25 21:28             ` Taylor Blau
2024-10-25  7:03           ` [PATCH 08/11] http-walker: use object_id instead of bare hash Jeff King
2024-10-25  7:05           ` [PATCH 09/11] packfile: convert find_sha1_pack() to use object_id Jeff King
2024-10-25  7:06           ` [PATCH 10/11] packfile: use object_id in find_pack_entry_one() Jeff King
2024-10-25 21:33             ` Taylor Blau
2024-10-25  7:08           ` [PATCH 11/11] packfile: use oidread() instead of hashcpy() to fill object_id Jeff King
2024-10-25 21:35           ` [PATCH 0/11] dumb-http pack index v1 regression + cleanups Taylor Blau
2024-10-21 20:23   ` Bug report: v2.47.0 cannot fetch version 1 pack indexes Taylor Blau
2024-10-22  5:00     ` Jeff King
2024-10-22 15:50       ` Taylor Blau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZxfJw1Ju8WBDktj1@nand.local \
    --to=me@ttaylorr.com \
    --cc=fox.gbr@townlong-yak.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).