From: Patrick Steinhardt <ps@pks.im>
To: Taylor Blau <me@ttaylorr.com>
Cc: Ramsay Jones <ramsay@ramsayjones.plus.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] meson: fix meson build on 'seen' branch
Date: Wed, 23 Oct 2024 11:05:19 +0200 [thread overview]
Message-ID: <Zxi8T2BoMX8ltM0E@pks.im> (raw)
In-Reply-To: <ZxbPkU+P8HUwVUDj@nand.local>
On Mon, Oct 21, 2024 at 06:02:57PM -0400, Taylor Blau wrote:
> On Sun, Oct 20, 2024 at 01:54:47AM +0100, Ramsay Jones wrote:
> >
> > Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> > ---
> >
> > Hi Taylor, Patrick,
> >
> > I tested the v3 patches on the base mentioned in the cover letter
> > without issues. In the interim, I noticed that the v3 patches had
> > been queued on the 'seen' branch. I tested with make, as usual, then
> > with meson (on Linux). This patch was required to fix the meson build
> > (just in case you weren't already aware, although I suspect you are!).
>
> Thanks. It would be nice to have this folded into Patrick's branch.
> Patrick: thoughts?
Yeah, I'll pick these up with v4 of this patch series. I'll also try to
make sure next time around that things work cleanly with "seen" and pick
up dependencies as required.
Patrick
next prev parent reply other threads:[~2024-10-23 9:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-20 0:54 [PATCH] meson: fix meson build on 'seen' branch Ramsay Jones
2024-10-21 22:02 ` Taylor Blau
2024-10-23 9:05 ` Patrick Steinhardt [this message]
2024-10-23 20:25 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zxi8T2BoMX8ltM0E@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).