From: Patrick Steinhardt <ps@pks.im>
To: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Cc: git@vger.kernel.org,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Taylor Blau <me@ttaylorr.com>
Subject: Re: [PATCH 3/3] compat/mingw: support POSIX semantics for atomic renames
Date: Thu, 24 Oct 2024 09:20:43 +0200 [thread overview]
Message-ID: <Zxn1S5DMtN8XIrxL@pks.im> (raw)
In-Reply-To: <d6669573-d5cc-4ad9-b248-95bda089bc6c@app.fastmail.com>
On Thu, Oct 24, 2024 at 09:18:18AM +0200, Kristoffer Haugsbakk wrote:
> On Thu, Oct 24, 2024, at 08:30, Patrick Steinhardt wrote:
> >> s/FILE_RENAME_POSIX_SEMANICS/FILE_RENAME_FLAG_POSIX_SEMANTICS/
> >
> > No, this is actually intentional. There are two different flags:
> >
> > - FILE_RENAME_POSIX_SEMANTICS is what ntifs.h exposes and what I've
> > been linking for documentation. This flag cannot be used though with
> > `FileRenameInfoEx`.
> >
> > - FILE_RENAME_FLAG_POSIX_SEMANTICS is what needs to be used with
> > `FileRenameInfoEx`, but it is undocumented.
> >
>
> I made a copy–paste mistake. :P I should have just pointed out this
> (missing T):
>
> _SEMANICS
>
> So you wrote it the correct-looking way in your first bullet
> point here.
Oh, indeed! Thanks.
Patrick
next prev parent reply other threads:[~2024-10-24 7:20 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 15:04 [PATCH 0/3] compat/mingw: implement POSIX-style atomic renames Patrick Steinhardt
2024-10-23 15:04 ` [PATCH 1/3] compat/mingw: share file handles created via `CreateFileW()` Patrick Steinhardt
2024-10-23 16:18 ` Kristoffer Haugsbakk
2024-10-23 17:25 ` Taylor Blau
2024-10-23 17:23 ` Taylor Blau
2024-10-23 17:25 ` Taylor Blau
2024-10-24 6:30 ` Patrick Steinhardt
2024-10-27 13:14 ` Johannes Sixt
2024-10-27 23:46 ` Taylor Blau
2024-10-23 15:05 ` [PATCH 2/3] compat/mingw: allow deletion of most opened files Patrick Steinhardt
2024-10-23 16:17 ` Kristoffer Haugsbakk
2024-10-23 17:30 ` Taylor Blau
2024-10-24 6:30 ` Patrick Steinhardt
2024-10-23 18:07 ` Taylor Blau
2024-10-23 15:05 ` [PATCH 3/3] compat/mingw: support POSIX semantics for atomic renames Patrick Steinhardt
2024-10-23 16:19 ` Kristoffer Haugsbakk
2024-10-24 6:30 ` Patrick Steinhardt
2024-10-24 7:18 ` Kristoffer Haugsbakk
2024-10-24 7:20 ` Patrick Steinhardt [this message]
2024-10-23 18:30 ` Taylor Blau
2024-10-23 15:36 ` [PATCH 0/3] compat/mingw: implement POSIX-style " Taylor Blau
2024-10-24 11:46 ` [PATCH v2 " Patrick Steinhardt
2024-10-24 11:46 ` [PATCH v2 1/3] compat/mingw: share file handles created via `CreateFileW()` Patrick Steinhardt
2024-10-24 11:46 ` [PATCH v2 2/3] compat/mingw: allow deletion of most opened files Patrick Steinhardt
2024-10-27 13:17 ` Johannes Sixt
2024-10-27 15:38 ` Patrick Steinhardt
2024-10-27 23:48 ` Taylor Blau
2024-10-27 23:51 ` Taylor Blau
2024-10-24 11:46 ` [PATCH v2 3/3] compat/mingw: support POSIX semantics for atomic renames Patrick Steinhardt
2024-10-27 13:23 ` Johannes Sixt
2024-10-27 15:38 ` Patrick Steinhardt
2024-10-27 16:31 ` Johannes Sixt
2024-10-27 17:27 ` Patrick Steinhardt
2024-10-27 21:36 ` Johannes Sixt
2024-10-27 23:50 ` Taylor Blau
2024-10-24 16:47 ` [PATCH v2 0/3] compat/mingw: implement POSIX-style " Taylor Blau
2024-10-27 13:27 ` Johannes Sixt
2024-10-27 15:39 ` [PATCH v3 " Patrick Steinhardt
2024-10-27 15:39 ` [PATCH v3 1/3] compat/mingw: share file handles created via `CreateFileW()` Patrick Steinhardt
2024-10-27 15:39 ` [PATCH v3 2/3] compat/mingw: allow deletion of most opened files Patrick Steinhardt
2024-10-27 15:39 ` [PATCH v3 3/3] compat/mingw: support POSIX semantics for atomic renames Patrick Steinhardt
2024-11-06 3:54 ` [PATCH v3 0/3] compat/mingw: implement POSIX-style " Junio C Hamano
2024-11-06 6:44 ` Johannes Sixt
2024-11-06 12:09 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zxn1S5DMtN8XIrxL@pks.im \
--to=ps@pks.im \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=kristofferhaugsbakk@fastmail.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).