git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Andrew Kreimer <algonell@gmail.com>
Cc: git@vger.kernel.org,
	Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Subject: Re: [PATCH v2] t: fix typos
Date: Thu, 24 Oct 2024 12:46:29 -0400	[thread overview]
Message-ID: <Zxp55YTXyRT5wGuo@nand.local> (raw)
In-Reply-To: <20241024114721.14270-1-algonell@gmail.com>

On Thu, Oct 24, 2024 at 02:47:20PM +0300, Andrew Kreimer wrote:
> Interdiff against v1:
>   diff --git a/t/t5528-push-default.sh b/t/t5528-push-default.sh
>   index aecd03d69f..1305b1cc25 100755
>   --- a/t/t5528-push-default.sh
>   +++ b/t/t5528-push-default.sh
>   @@ -147,7 +147,7 @@ test_expect_success 'push from/to new branch fails with upstream and simple ' '
>    #  - the default push succeeds
>    #
>    # A previous test expected this to fail, but for the wrong reasons:
>   -# it expected a fail because the branch is new and cannot be pushed, but
>   +# it expected to fail because the branch is new and cannot be pushed, but
>    # in fact it was failing because of an ambiguous remote
>    #
>    test_expect_failure 'push from/to new branch fails with matching ' '

Thanks, looks good to me. Let's start merging this one down.

Thanks,
Taylor

  reply	other threads:[~2024-10-24 16:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-23 17:01 [PATCH] t: fix typos Andrew Kreimer
2024-10-23 18:00 ` Kristoffer Haugsbakk
2024-10-23 18:33   ` Taylor Blau
2024-10-24 11:44     ` Andrew Kreimer
2024-10-24 11:47 ` [PATCH v2] " Andrew Kreimer
2024-10-24 16:46   ` Taylor Blau [this message]
2024-10-24 17:07   ` Kristoffer Haugsbakk
2024-10-25  9:20     ` Andrew Kreimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zxp55YTXyRT5wGuo@nand.local \
    --to=me@ttaylorr.com \
    --cc=algonell@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=kristofferhaugsbakk@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).