git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: git@vger.kernel.org, ps@pks.im, kristofferhaugsbakk@fastmail.com,
	jltobler@gmail.com
Subject: Re: [PATCH v3] CodingGuidelines: discourage arbitrary suffixes in function names
Date: Thu, 24 Oct 2024 12:50:55 -0400	[thread overview]
Message-ID: <Zxp67zpIsxAe15gN@nand.local> (raw)
In-Reply-To: <20241024105357.2605168-1-karthik.188@gmail.com>

On Thu, Oct 24, 2024 at 12:53:57PM +0200, Karthik Nayak wrote:
> We often name functions with arbitrary suffixes like `_1` as an
> extension of another existing function. This creates confusion and
> doesn't provide good clarity into the functions purpose. Let's document
> good function naming etiquette in our CodingGuidelines.
>
> Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
> ---

Thanks, I think that this version is looking quite good. Let's let it
simmer a little longer so folks can continue to discuss, but I think
that this is looking quite good.

Thanks,
Taylor

      parent reply	other threads:[~2024-10-24 16:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <https://lore.kernel.org/r/20241021124145.636561-1-karthik.188@gmail.com>
2024-10-24 10:53 ` [PATCH v3] CodingGuidelines: discourage arbitrary suffixes in function names Karthik Nayak
2024-10-24 11:02   ` karthik nayak
2024-10-24 16:50   ` Taylor Blau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zxp67zpIsxAe15gN@nand.local \
    --to=me@ttaylorr.com \
    --cc=git@vger.kernel.org \
    --cc=jltobler@gmail.com \
    --cc=karthik.188@gmail.com \
    --cc=kristofferhaugsbakk@fastmail.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).