git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Jeff King <peff@peff.net>
Cc: Josh Poimboeuf <jpoimboe@kernel.org>,
	git@vger.kernel.org, Derrick Stolee <stolee@gmail.com>
Subject: Re: [BUG] "git describe --match" performance
Date: Thu, 31 Oct 2024 15:01:06 -0400	[thread overview]
Message-ID: <ZyPT8lsloCG4QLai@nand.local> (raw)
In-Reply-To: <20241031170526.GA2277590@coredump.intra.peff.net>

On Thu, Oct 31, 2024 at 01:05:26PM -0400, Jeff King wrote:
> I think we talked long ago about computing commit-graphs over the
> grafted state, and then using those graphs as long as the graft state
> remained the same. But I don't think we ever implemented anything.
>
> Another possibility (that I don't recall we've ever discussed) is
> partially using commit graphs. Some commit properties, like generation
> numbers, depend on other commits. So a graft at the bottom of history is
> going to rewrite the generations for all of the descendants. But we
> could still use the graph information to load the parents and trees of
> all of the non-grafted commits. Those are still valid even in a grafted
> situation, and that's what's providing most of the speed up in this case
> (without it, we're literally zlib inflating each commit we traverse in
> order to find its parents, versus an integer lookup via the
> commit-graph).
>
> That might not be _too_ hard to implement. In theory, anyway. :)

Adding Stolee (CC'd), our resident commit-graph expert, to see if they
have any thoughts.

Thanks,
Taylor

  reply	other threads:[~2024-10-31 19:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-30  4:43 [BUG] "git describe --match" performance Josh Poimboeuf
2024-10-31 11:47 ` Jeff King
2024-10-31 15:10   ` Josh Poimboeuf
2024-10-31 15:31     ` Jeff King
2024-10-31 16:25       ` Josh Poimboeuf
2024-10-31 17:05         ` Jeff King
2024-10-31 19:01           ` Taylor Blau [this message]
2024-10-31 16:14   ` Kristoffer Haugsbakk
2024-10-31 17:20     ` Jeff King
2024-10-31 19:00   ` Taylor Blau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZyPT8lsloCG4QLai@nand.local \
    --to=me@ttaylorr.com \
    --cc=git@vger.kernel.org \
    --cc=jpoimboe@kernel.org \
    --cc=peff@peff.net \
    --cc=stolee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).