git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Jeff King <peff@peff.net>
Cc: Josh Poimboeuf <jpoimboe@kernel.org>, git@vger.kernel.org
Subject: Re: [BUG] "git describe --match" performance
Date: Thu, 31 Oct 2024 15:00:22 -0400	[thread overview]
Message-ID: <ZyPTxgSFiQpZG8qe@nand.local> (raw)
In-Reply-To: <20241031114731.GA608553@coredump.intra.peff.net>

On Thu, Oct 31, 2024 at 07:47:31AM -0400, Jeff King wrote:
> I think we'll build the commit graph file by default these days when you
> run "git gc". But we don't build it immediately after cloning. Perhaps
> we should change that.

I think that would be a reasonable thing to do. We already have
fetch.writeCommitGraph and gc.writeCommitGraph, so it seems like a
natural extension to add clone.writeCommitGraph.

I don't have a strong feeling about what the default should be, although
I err on the side of "true". Most repositories cloned will be small
enough that writing a commit-graph upon clone shouldn't take too long.
So the savings it will provide will be well worth the marginal increase
in perceived clone time.

Thanks,
Taylor

      parent reply	other threads:[~2024-10-31 19:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-30  4:43 [BUG] "git describe --match" performance Josh Poimboeuf
2024-10-31 11:47 ` Jeff King
2024-10-31 15:10   ` Josh Poimboeuf
2024-10-31 15:31     ` Jeff King
2024-10-31 16:25       ` Josh Poimboeuf
2024-10-31 17:05         ` Jeff King
2024-10-31 19:01           ` Taylor Blau
2024-10-31 16:14   ` Kristoffer Haugsbakk
2024-10-31 17:20     ` Jeff King
2024-10-31 19:00   ` Taylor Blau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZyPTxgSFiQpZG8qe@nand.local \
    --to=me@ttaylorr.com \
    --cc=git@vger.kernel.org \
    --cc=jpoimboe@kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).