From: Taylor Blau <me@ttaylorr.com>
To: Caleb White <cdwhite3@pm.me>
Cc: git@vger.kernel.org, Phillip Wood <phillip.wood123@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
Eric Sunshine <sunshine@sunshineco.com>
Subject: Re: [PATCH v3 0/8] Allow relative worktree linking to be configured by the user
Date: Thu, 31 Oct 2024 15:20:41 -0400 [thread overview]
Message-ID: <ZyPYiffYRDK/4LdG@nand.local> (raw)
In-Reply-To: <20241031-wt_relative_options-v3-0-3e44ccdf64e6@pm.me>
On Thu, Oct 31, 2024 at 05:05:23AM +0000, Caleb White wrote:
> Caleb White (8):
> setup: correctly reinitialize repository version
> worktree: add `relativeWorktrees` extension
> worktree: refactor infer_backlink return
> worktree: add `write_worktree_linking_files()` function
> worktree: add relative cli/config options to `add` command
> worktree: add relative cli/config options to `move` command
> worktree: add relative cli/config options to `repair` command
> worktree: refactor `repair_worktree_after_gitdir_move()`
This version of the topic, as well as the previous round, appear to
break CI:
https://github.com/ttaylorr/git/actions/runs/11602969587
An easy reproduction locally is to run t/t5504-fetch-receive-strict.sh
when built with 'make SANITIZE=leak' and run with
'GIT_TEST_DEFAULT_REF_FORMAT=reftable'.
I'm going to kick this topic out of jch for the time being as it breaks
CI, but please do send another round once you have fixed the issue. In
the future, please verify that your series does not break CI before
sending it to the list. Thanks.
Thanks,
Taylor
next prev parent reply other threads:[~2024-10-31 19:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-31 5:05 [PATCH v3 0/8] Allow relative worktree linking to be configured by the user Caleb White
2024-10-31 5:05 ` [PATCH v3 1/8] setup: correctly reinitialize repository version Caleb White
2024-10-31 5:05 ` [PATCH v3 2/8] worktree: add `relativeWorktrees` extension Caleb White
2024-10-31 5:05 ` [PATCH v3 3/8] worktree: refactor infer_backlink return Caleb White
2024-10-31 5:05 ` [PATCH v3 4/8] worktree: add `write_worktree_linking_files()` function Caleb White
2024-10-31 5:05 ` [PATCH v3 5/8] worktree: add relative cli/config options to `add` command Caleb White
2024-10-31 5:06 ` [PATCH v3 6/8] worktree: add relative cli/config options to `move` command Caleb White
2024-10-31 5:06 ` [PATCH v3 7/8] worktree: add relative cli/config options to `repair` command Caleb White
2024-10-31 5:06 ` [PATCH v3 8/8] worktree: refactor `repair_worktree_after_gitdir_move()` Caleb White
2024-10-31 19:20 ` Taylor Blau [this message]
2024-10-31 19:52 ` [PATCH v3 0/8] Allow relative worktree linking to be configured by the user Caleb White
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyPYiffYRDK/4LdG@nand.local \
--to=me@ttaylorr.com \
--cc=cdwhite3@pm.me \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=phillip.wood123@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).