From: Taylor Blau <me@ttaylorr.com>
To: Seyi Kuforiji <kuforiji98@gmail.com>
Cc: git@vger.kernel.org, ps@pks.im, phillip.wood@dunelm.org.uk,
kristofferhaugsbakk@fastmail.com
Subject: Re: [PATCH] t9101: Refactor test_expect_success format
Date: Thu, 31 Oct 2024 16:15:30 -0400 [thread overview]
Message-ID: <ZyPlYkwsFrxH+JwE@nand.local> (raw)
In-Reply-To: <20241031094554.68916-1-kuforiji98@gmail.com>
On Thu, Oct 31, 2024 at 10:45:53AM +0100, Seyi Kuforiji wrote:
> The current script uses an outdated formatting style for
> test_expect_success blocks, where each argument is separated by a
> backslash and newline. This style can lead to readability issues and
> makes it harder to maintain the script.
>
> The modern style consolidates
> the multi-line command arguments into a single quoted block, which
Strange line wrapping?
> improves readability, maintainability, and aligns the code with current
> coding standards.
>
> Signed-off-by: Seyi Kuforiji <kuforiji98@gmail.com>
> ---
> t/t9101-git-svn-props.sh | 48 ++++++++++++++++++++++------------------
> 1 file changed, 26 insertions(+), 22 deletions(-)
This does not apply cleanly on 'master', so I assume that you wanted it
based on sk/t9101-cleanup. That's fine, but please let me know in the
future in case it's every less obvious :-).
The changes themselves all look quite sensible, though.
Thanks,
Taylor
next prev parent reply other threads:[~2024-10-31 20:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-31 9:45 [PATCH] t9101: Refactor test_expect_success format Seyi Kuforiji
2024-10-31 20:15 ` Taylor Blau [this message]
2024-11-01 7:51 ` Seyi Chamber
2024-11-01 14:42 ` Taylor Blau
2024-11-02 10:28 ` [PATCH v2] " Seyi Kuforiji
2024-11-18 8:34 ` Seyi Chamber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyPlYkwsFrxH+JwE@nand.local \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=kristofferhaugsbakk@fastmail.com \
--cc=kuforiji98@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).