From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Taylor Blau <me@ttaylorr.com>,
Patrick Steinhardt <ps@pks.im>
Subject: Re: [PATCH 2/3] ci: remove clause for Ubuntu 16.04
Date: Fri, 1 Nov 2024 00:38:31 +0000 [thread overview]
Message-ID: <ZyQjB8iLM1FIDbGe@tapette.crustytoothpaste.net> (raw)
In-Reply-To: <xmqqv7x74ws9.fsf@gitster.g>
[-- Attachment #1: Type: text/plain, Size: 666 bytes --]
On 2024-11-01 at 00:34:14, Junio C Hamano wrote:
> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
>
> > We're no longer testing this version and it's well beyond regular LTS
> > support now, so remove the stanza for it from the case statement in our
> > CI code.
>
> Something like "we replaced it with 20.04 which does not need the
> corresponding special casing" would be necessary to explain why this
> is a good change, as opposed to an equally plausible-looking patch
> that replaces 16.04 with 20.04 and otherwise keeps the "stanza".
Sure, I can mention that in v2.
--
brian m. carlson (they/them or he/him)
Toronto, Ontario, CA
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2024-11-01 0:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-31 23:49 [PATCH 0/3] Improve CI testing of older systems brian m. carlson
2024-10-31 23:49 ` [PATCH 1/3] gitlab-ci: switch from Ubuntu 16.04 to 20.04 brian m. carlson
2024-10-31 23:49 ` [PATCH 2/3] ci: remove clause for Ubuntu 16.04 brian m. carlson
2024-11-01 0:34 ` Junio C Hamano
2024-11-01 0:38 ` brian m. carlson [this message]
2024-11-01 0:41 ` Junio C Hamano
2024-10-31 23:49 ` [PATCH 3/3] Add additional CI jobs to avoid accidental breakage brian m. carlson
2024-11-04 11:36 ` [PATCH 0/3] Improve CI testing of older systems Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyQjB8iLM1FIDbGe@tapette.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).