git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] t9101: Refactor test_expect_success format
@ 2024-10-31  9:45 Seyi Kuforiji
  2024-10-31 20:15 ` Taylor Blau
  2024-11-02 10:28 ` [PATCH v2] " Seyi Kuforiji
  0 siblings, 2 replies; 6+ messages in thread
From: Seyi Kuforiji @ 2024-10-31  9:45 UTC (permalink / raw)
  To: git; +Cc: ps, phillip.wood, kristofferhaugsbakk, me, Seyi Kuforiji

The current script uses an outdated formatting style for
test_expect_success blocks, where each argument is separated by a
backslash and newline. This style can lead to readability issues and
makes it harder to maintain the script.

The modern style consolidates
the multi-line command arguments into a single quoted block, which
improves readability, maintainability, and aligns the code with current
coding standards.

Signed-off-by: Seyi Kuforiji <kuforiji98@gmail.com>
---
 t/t9101-git-svn-props.sh | 48 ++++++++++++++++++++++------------------
 1 file changed, 26 insertions(+), 22 deletions(-)

diff --git a/t/t9101-git-svn-props.sh b/t/t9101-git-svn-props.sh
index b2ee626b9a..792f7896e4 100755
--- a/t/t9101-git-svn-props.sh
+++ b/t/t9101-git-svn-props.sh
@@ -73,12 +73,13 @@ test_expect_success 'initialize git svn' 'git svn init "$svnrepo"'
 test_expect_success 'fetch revisions from svn' 'git svn fetch'
 
 name='test svn:keywords ignoring'
-test_expect_success "$name" \
-	'git checkout -b mybranch remotes/git-svn &&
+test_expect_success "$name" '
+	git checkout -b mybranch remotes/git-svn &&
 	echo Hi again >>kw.c &&
 	git commit -a -m "test keywords ignoring" &&
 	git svn set-tree remotes/git-svn..mybranch &&
-	git pull . remotes/git-svn'
+	git pull . remotes/git-svn
+'
 
 expect='/* $Id$ */'
 got="$(sed -ne 2p kw.c)"
@@ -94,10 +95,11 @@ test_expect_success "propset CR on crlf files" '
 	 )
 '
 
-test_expect_success 'fetch and pull latest from svn and checkout a new wc' \
-	'git svn fetch &&
-	 git pull . remotes/git-svn &&
-	 svn_cmd co "$svnrepo" new_wc'
+test_expect_success 'fetch and pull latest from svn and checkout a new wc' '
+	git svn fetch &&
+	git pull . remotes/git-svn &&
+	svn_cmd co "$svnrepo" new_wc
+'
 
 for i in crlf ne_crlf lf ne_lf cr ne_cr empty_cr empty_lf empty empty_crlf
 do
@@ -110,15 +112,17 @@ cd test_wc
 	printf '$Id$\rHello\rWorld' >ne_cr
 	a_cr=$(printf '$Id$\r\nHello\r\nWorld\r\n' | git hash-object --stdin)
 	a_ne_cr=$(printf '$Id$\r\nHello\r\nWorld' | git hash-object --stdin)
-	test_expect_success 'Set CRLF on cr files' \
-	'svn_cmd propset svn:eol-style CRLF cr &&
-	 svn_cmd propset svn:eol-style CRLF ne_cr &&
-	 svn_cmd propset svn:keywords Id cr &&
-	 svn_cmd propset svn:keywords Id ne_cr &&
-	 svn_cmd commit -m "propset CRLF on cr files"'
+	test_expect_success 'Set CRLF on cr files' '
+		svn_cmd propset svn:eol-style CRLF cr &&
+		svn_cmd propset svn:eol-style CRLF ne_cr &&
+		svn_cmd propset svn:keywords Id cr &&
+		svn_cmd propset svn:keywords Id ne_cr &&
+		svn_cmd commit -m "propset CRLF on cr files"
+	'
 cd ..
-test_expect_success 'fetch and pull latest from svn' \
-	'git svn fetch && git pull . remotes/git-svn'
+test_expect_success 'fetch and pull latest from svn' '
+	git svn fetch && git pull . remotes/git-svn
+'
 
 b_cr="$(git hash-object cr)"
 b_ne_cr="$(git hash-object ne_cr)"
@@ -141,7 +145,7 @@ cat >show-ignore.expect <<\EOF
 /deeply/nested/directory/no-such-file*
 EOF
 
-test_expect_success 'test show-ignore' "
+test_expect_success 'test show-ignore' '
 	(
 		cd test_wc &&
 		mkdir -p deeply/nested/directory &&
@@ -155,7 +159,7 @@ no-such-file*
 	) &&
 	git svn show-ignore >show-ignore.got &&
 	cmp show-ignore.expect show-ignore.got
-"
+'
 
 cat >create-ignore.expect <<\EOF
 /no-such-file*
@@ -170,7 +174,7 @@ cat >create-ignore-index.expect <<EOF
 100644 $expectoid 0	deeply/nested/directory/.gitignore
 EOF
 
-test_expect_success 'test create-ignore' "
+test_expect_success 'test create-ignore' '
 	git svn fetch && git pull . remotes/git-svn &&
 	git svn create-ignore &&
 	cmp ./.gitignore create-ignore.expect &&
@@ -179,7 +183,7 @@ test_expect_success 'test create-ignore' "
 	cmp ./deeply/nested/directory/.gitignore create-ignore.expect &&
 	git ls-files -s >ls_files_result &&
 	grep gitignore ls_files_result | cmp - create-ignore-index.expect
-	"
+'
 
 cat >prop.expect <<\EOF
 
@@ -207,7 +211,7 @@ test_expect_success 'test propget' '
 	test_propget svn:ignore nested/ ../prop.expect &&
 	test_propget svn:ignore ./nested ../prop.expect &&
 	test_propget svn:ignore .././deeply/nested ../prop.expect
-	'
+'
 
 cat >prop.expect <<\EOF
 Properties on '.':
@@ -225,12 +229,12 @@ Properties on 'nested/directory/.keep':
   svn:entry:uuid
 EOF
 
-test_expect_success 'test proplist' "
+test_expect_success 'test proplist' '
 	git svn proplist . >actual &&
 	cmp prop.expect actual &&
 
 	git svn proplist nested/directory/.keep >actual &&
 	cmp prop2.expect actual
-	"
+'
 
 test_done
-- 
2.47.0.86.g15030f9556


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] t9101: Refactor test_expect_success format
  2024-10-31  9:45 [PATCH] t9101: Refactor test_expect_success format Seyi Kuforiji
@ 2024-10-31 20:15 ` Taylor Blau
  2024-11-01  7:51   ` Seyi Chamber
  2024-11-02 10:28 ` [PATCH v2] " Seyi Kuforiji
  1 sibling, 1 reply; 6+ messages in thread
From: Taylor Blau @ 2024-10-31 20:15 UTC (permalink / raw)
  To: Seyi Kuforiji; +Cc: git, ps, phillip.wood, kristofferhaugsbakk

On Thu, Oct 31, 2024 at 10:45:53AM +0100, Seyi Kuforiji wrote:
> The current script uses an outdated formatting style for
> test_expect_success blocks, where each argument is separated by a
> backslash and newline. This style can lead to readability issues and
> makes it harder to maintain the script.
>
> The modern style consolidates
> the multi-line command arguments into a single quoted block, which

Strange line wrapping?

> improves readability, maintainability, and aligns the code with current
> coding standards.
>
> Signed-off-by: Seyi Kuforiji <kuforiji98@gmail.com>
> ---
>  t/t9101-git-svn-props.sh | 48 ++++++++++++++++++++++------------------
>  1 file changed, 26 insertions(+), 22 deletions(-)

This does not apply cleanly on 'master', so I assume that you wanted it
based on sk/t9101-cleanup. That's fine, but please let me know in the
future in case it's every less obvious :-).

The changes themselves all look quite sensible, though.

Thanks,
Taylor

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] t9101: Refactor test_expect_success format
  2024-10-31 20:15 ` Taylor Blau
@ 2024-11-01  7:51   ` Seyi Chamber
  2024-11-01 14:42     ` Taylor Blau
  0 siblings, 1 reply; 6+ messages in thread
From: Seyi Chamber @ 2024-11-01  7:51 UTC (permalink / raw)
  To: Taylor Blau; +Cc: git, ps, phillip.wood, kristofferhaugsbakk

On Thu, 31 Oct 2024 at 21:15, Taylor Blau <me@ttaylorr.com> wrote:
>
> On Thu, Oct 31, 2024 at 10:45:53AM +0100, Seyi Kuforiji wrote:
> > The current script uses an outdated formatting style for
> > test_expect_success blocks, where each argument is separated by a
> > backslash and newline. This style can lead to readability issues and
> > makes it harder to maintain the script.
> >
> > The modern style consolidates
> > the multi-line command arguments into a single quoted block, which
>
> Strange line wrapping?
>

That error probably occurred while I was editing the message. Should I
edit and send an updated patch?

> > improves readability, maintainability, and aligns the code with current
> > coding standards.
> >
> > Signed-off-by: Seyi Kuforiji <kuforiji98@gmail.com>
> > ---
> >  t/t9101-git-svn-props.sh | 48 ++++++++++++++++++++++------------------
> >  1 file changed, 26 insertions(+), 22 deletions(-)
>
> This does not apply cleanly on 'master', so I assume that you wanted it
> based on sk/t9101-cleanup. That's fine, but please let me know in the
> future in case it's every less obvious :-).
>
> The changes themselves all look quite sensible, though.
>
> Thanks,
> Taylor

Thanks, Taylor for pointing out this issue. I have rebased my change
onto the latest master branch and resolved the conflicts for future
updates.

Thanks,
Seyi

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] t9101: Refactor test_expect_success format
  2024-11-01  7:51   ` Seyi Chamber
@ 2024-11-01 14:42     ` Taylor Blau
  0 siblings, 0 replies; 6+ messages in thread
From: Taylor Blau @ 2024-11-01 14:42 UTC (permalink / raw)
  To: Seyi Chamber; +Cc: git, ps, phillip.wood, kristofferhaugsbakk

On Fri, Nov 01, 2024 at 08:51:11AM +0100, Seyi Chamber wrote:
> On Thu, 31 Oct 2024 at 21:15, Taylor Blau <me@ttaylorr.com> wrote:
> >
> > On Thu, Oct 31, 2024 at 10:45:53AM +0100, Seyi Kuforiji wrote:
> > > The current script uses an outdated formatting style for
> > > test_expect_success blocks, where each argument is separated by a
> > > backslash and newline. This style can lead to readability issues and
> > > makes it harder to maintain the script.
> > >
> > > The modern style consolidates
> > > the multi-line command arguments into a single quoted block, which
> >
> > Strange line wrapping?
> >
>
> That error probably occurred while I was editing the message. Should I
> edit and send an updated patch?

Please do so, thanks.

> > > improves readability, maintainability, and aligns the code with current
> > > coding standards.
> > >
> > > Signed-off-by: Seyi Kuforiji <kuforiji98@gmail.com>
> > > ---
> > >  t/t9101-git-svn-props.sh | 48 ++++++++++++++++++++++------------------
> > >  1 file changed, 26 insertions(+), 22 deletions(-)
> >
> > This does not apply cleanly on 'master', so I assume that you wanted it
> > based on sk/t9101-cleanup. That's fine, but please let me know in the
> > future in case it's every less obvious :-).
> >
> > The changes themselves all look quite sensible, though.
> >
> > Thanks,
> > Taylor
>
> Thanks, Taylor for pointing out this issue. I have rebased my change
> onto the latest master branch and resolved the conflicts for future
> updates.

There is no specific need to rebase on top of current 'master' unless
failing to do so will cause the maintainer to see a conflicted state
when applying.

Unless told otherwise, I will apply new rounds of existing patch series
onto top of their original base.

Thanks,
Taylor

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2] t9101: Refactor test_expect_success format
  2024-10-31  9:45 [PATCH] t9101: Refactor test_expect_success format Seyi Kuforiji
  2024-10-31 20:15 ` Taylor Blau
@ 2024-11-02 10:28 ` Seyi Kuforiji
  2024-11-18  8:34   ` Seyi Chamber
  1 sibling, 1 reply; 6+ messages in thread
From: Seyi Kuforiji @ 2024-11-02 10:28 UTC (permalink / raw)
  To: git; +Cc: ps, phillip.wood, kristofferhaugsbakk, me, Seyi Kuforiji

The current script uses an outdated formatting style for
test_expect_success blocks, where each argument is separated by a
backslash and newline. This style can lead to readability issues and
makes it harder to maintain the script.The modern style consolidates the
multi-line command arguments into a single quoted block, which improves
readability, maintainability, and aligns the code with current coding
standards.

Signed-off-by: Seyi Kuforiji <kuforiji98@gmail.com>
---
 t/t9101-git-svn-props.sh | 48 ++++++++++++++++++++++------------------
 1 file changed, 26 insertions(+), 22 deletions(-)

diff --git a/t/t9101-git-svn-props.sh b/t/t9101-git-svn-props.sh
index b2ee626b9a..792f7896e4 100755
--- a/t/t9101-git-svn-props.sh
+++ b/t/t9101-git-svn-props.sh
@@ -73,12 +73,13 @@ test_expect_success 'initialize git svn' 'git svn init "$svnrepo"'
 test_expect_success 'fetch revisions from svn' 'git svn fetch'
 
 name='test svn:keywords ignoring'
-test_expect_success "$name" \
-	'git checkout -b mybranch remotes/git-svn &&
+test_expect_success "$name" '
+	git checkout -b mybranch remotes/git-svn &&
 	echo Hi again >>kw.c &&
 	git commit -a -m "test keywords ignoring" &&
 	git svn set-tree remotes/git-svn..mybranch &&
-	git pull . remotes/git-svn'
+	git pull . remotes/git-svn
+'
 
 expect='/* $Id$ */'
 got="$(sed -ne 2p kw.c)"
@@ -94,10 +95,11 @@ test_expect_success "propset CR on crlf files" '
 	 )
 '
 
-test_expect_success 'fetch and pull latest from svn and checkout a new wc' \
-	'git svn fetch &&
-	 git pull . remotes/git-svn &&
-	 svn_cmd co "$svnrepo" new_wc'
+test_expect_success 'fetch and pull latest from svn and checkout a new wc' '
+	git svn fetch &&
+	git pull . remotes/git-svn &&
+	svn_cmd co "$svnrepo" new_wc
+'
 
 for i in crlf ne_crlf lf ne_lf cr ne_cr empty_cr empty_lf empty empty_crlf
 do
@@ -110,15 +112,17 @@ cd test_wc
 	printf '$Id$\rHello\rWorld' >ne_cr
 	a_cr=$(printf '$Id$\r\nHello\r\nWorld\r\n' | git hash-object --stdin)
 	a_ne_cr=$(printf '$Id$\r\nHello\r\nWorld' | git hash-object --stdin)
-	test_expect_success 'Set CRLF on cr files' \
-	'svn_cmd propset svn:eol-style CRLF cr &&
-	 svn_cmd propset svn:eol-style CRLF ne_cr &&
-	 svn_cmd propset svn:keywords Id cr &&
-	 svn_cmd propset svn:keywords Id ne_cr &&
-	 svn_cmd commit -m "propset CRLF on cr files"'
+	test_expect_success 'Set CRLF on cr files' '
+		svn_cmd propset svn:eol-style CRLF cr &&
+		svn_cmd propset svn:eol-style CRLF ne_cr &&
+		svn_cmd propset svn:keywords Id cr &&
+		svn_cmd propset svn:keywords Id ne_cr &&
+		svn_cmd commit -m "propset CRLF on cr files"
+	'
 cd ..
-test_expect_success 'fetch and pull latest from svn' \
-	'git svn fetch && git pull . remotes/git-svn'
+test_expect_success 'fetch and pull latest from svn' '
+	git svn fetch && git pull . remotes/git-svn
+'
 
 b_cr="$(git hash-object cr)"
 b_ne_cr="$(git hash-object ne_cr)"
@@ -141,7 +145,7 @@ cat >show-ignore.expect <<\EOF
 /deeply/nested/directory/no-such-file*
 EOF
 
-test_expect_success 'test show-ignore' "
+test_expect_success 'test show-ignore' '
 	(
 		cd test_wc &&
 		mkdir -p deeply/nested/directory &&
@@ -155,7 +159,7 @@ no-such-file*
 	) &&
 	git svn show-ignore >show-ignore.got &&
 	cmp show-ignore.expect show-ignore.got
-"
+'
 
 cat >create-ignore.expect <<\EOF
 /no-such-file*
@@ -170,7 +174,7 @@ cat >create-ignore-index.expect <<EOF
 100644 $expectoid 0	deeply/nested/directory/.gitignore
 EOF
 
-test_expect_success 'test create-ignore' "
+test_expect_success 'test create-ignore' '
 	git svn fetch && git pull . remotes/git-svn &&
 	git svn create-ignore &&
 	cmp ./.gitignore create-ignore.expect &&
@@ -179,7 +183,7 @@ test_expect_success 'test create-ignore' "
 	cmp ./deeply/nested/directory/.gitignore create-ignore.expect &&
 	git ls-files -s >ls_files_result &&
 	grep gitignore ls_files_result | cmp - create-ignore-index.expect
-	"
+'
 
 cat >prop.expect <<\EOF
 
@@ -207,7 +211,7 @@ test_expect_success 'test propget' '
 	test_propget svn:ignore nested/ ../prop.expect &&
 	test_propget svn:ignore ./nested ../prop.expect &&
 	test_propget svn:ignore .././deeply/nested ../prop.expect
-	'
+'
 
 cat >prop.expect <<\EOF
 Properties on '.':
@@ -225,12 +229,12 @@ Properties on 'nested/directory/.keep':
   svn:entry:uuid
 EOF
 
-test_expect_success 'test proplist' "
+test_expect_success 'test proplist' '
 	git svn proplist . >actual &&
 	cmp prop.expect actual &&
 
 	git svn proplist nested/directory/.keep >actual &&
 	cmp prop2.expect actual
-	"
+'
 
 test_done
-- 
2.47.0.86.g15030f9556


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] t9101: Refactor test_expect_success format
  2024-11-02 10:28 ` [PATCH v2] " Seyi Kuforiji
@ 2024-11-18  8:34   ` Seyi Chamber
  0 siblings, 0 replies; 6+ messages in thread
From: Seyi Chamber @ 2024-11-18  8:34 UTC (permalink / raw)
  To: git; +Cc: ps, phillip.wood, kristofferhaugsbakk, me

On Sat, 2 Nov 2024 at 11:28, Seyi Kuforiji <kuforiji98@gmail.com> wrote:
>
> The current script uses an outdated formatting style for
> test_expect_success blocks, where each argument is separated by a
> backslash and newline. This style can lead to readability issues and
> makes it harder to maintain the script.The modern style consolidates the
> multi-line command arguments into a single quoted block, which improves
> readability, maintainability, and aligns the code with current coding
> standards.
>
> Signed-off-by: Seyi Kuforiji <kuforiji98@gmail.com>
> ---
>  t/t9101-git-svn-props.sh | 48 ++++++++++++++++++++++------------------
>  1 file changed, 26 insertions(+), 22 deletions(-)
>
> diff --git a/t/t9101-git-svn-props.sh b/t/t9101-git-svn-props.sh
> index b2ee626b9a..792f7896e4 100755
> --- a/t/t9101-git-svn-props.sh
> +++ b/t/t9101-git-svn-props.sh
> @@ -73,12 +73,13 @@ test_expect_success 'initialize git svn' 'git svn init "$svnrepo"'
>  test_expect_success 'fetch revisions from svn' 'git svn fetch'
>
>  name='test svn:keywords ignoring'
> -test_expect_success "$name" \
> -       'git checkout -b mybranch remotes/git-svn &&
> +test_expect_success "$name" '
> +       git checkout -b mybranch remotes/git-svn &&
>         echo Hi again >>kw.c &&
>         git commit -a -m "test keywords ignoring" &&
>         git svn set-tree remotes/git-svn..mybranch &&
> -       git pull . remotes/git-svn'
> +       git pull . remotes/git-svn
> +'
>
>  expect='/* $Id$ */'
>  got="$(sed -ne 2p kw.c)"
> @@ -94,10 +95,11 @@ test_expect_success "propset CR on crlf files" '
>          )
>  '
>
> -test_expect_success 'fetch and pull latest from svn and checkout a new wc' \
> -       'git svn fetch &&
> -        git pull . remotes/git-svn &&
> -        svn_cmd co "$svnrepo" new_wc'
> +test_expect_success 'fetch and pull latest from svn and checkout a new wc' '
> +       git svn fetch &&
> +       git pull . remotes/git-svn &&
> +       svn_cmd co "$svnrepo" new_wc
> +'
>
>  for i in crlf ne_crlf lf ne_lf cr ne_cr empty_cr empty_lf empty empty_crlf
>  do
> @@ -110,15 +112,17 @@ cd test_wc
>         printf '$Id$\rHello\rWorld' >ne_cr
>         a_cr=$(printf '$Id$\r\nHello\r\nWorld\r\n' | git hash-object --stdin)
>         a_ne_cr=$(printf '$Id$\r\nHello\r\nWorld' | git hash-object --stdin)
> -       test_expect_success 'Set CRLF on cr files' \
> -       'svn_cmd propset svn:eol-style CRLF cr &&
> -        svn_cmd propset svn:eol-style CRLF ne_cr &&
> -        svn_cmd propset svn:keywords Id cr &&
> -        svn_cmd propset svn:keywords Id ne_cr &&
> -        svn_cmd commit -m "propset CRLF on cr files"'
> +       test_expect_success 'Set CRLF on cr files' '
> +               svn_cmd propset svn:eol-style CRLF cr &&
> +               svn_cmd propset svn:eol-style CRLF ne_cr &&
> +               svn_cmd propset svn:keywords Id cr &&
> +               svn_cmd propset svn:keywords Id ne_cr &&
> +               svn_cmd commit -m "propset CRLF on cr files"
> +       '
>  cd ..
> -test_expect_success 'fetch and pull latest from svn' \
> -       'git svn fetch && git pull . remotes/git-svn'
> +test_expect_success 'fetch and pull latest from svn' '
> +       git svn fetch && git pull . remotes/git-svn
> +'
>
>  b_cr="$(git hash-object cr)"
>  b_ne_cr="$(git hash-object ne_cr)"
> @@ -141,7 +145,7 @@ cat >show-ignore.expect <<\EOF
>  /deeply/nested/directory/no-such-file*
>  EOF
>
> -test_expect_success 'test show-ignore' "
> +test_expect_success 'test show-ignore' '
>         (
>                 cd test_wc &&
>                 mkdir -p deeply/nested/directory &&
> @@ -155,7 +159,7 @@ no-such-file*
>         ) &&
>         git svn show-ignore >show-ignore.got &&
>         cmp show-ignore.expect show-ignore.got
> -"
> +'
>
>  cat >create-ignore.expect <<\EOF
>  /no-such-file*
> @@ -170,7 +174,7 @@ cat >create-ignore-index.expect <<EOF
>  100644 $expectoid 0    deeply/nested/directory/.gitignore
>  EOF
>
> -test_expect_success 'test create-ignore' "
> +test_expect_success 'test create-ignore' '
>         git svn fetch && git pull . remotes/git-svn &&
>         git svn create-ignore &&
>         cmp ./.gitignore create-ignore.expect &&
> @@ -179,7 +183,7 @@ test_expect_success 'test create-ignore' "
>         cmp ./deeply/nested/directory/.gitignore create-ignore.expect &&
>         git ls-files -s >ls_files_result &&
>         grep gitignore ls_files_result | cmp - create-ignore-index.expect
> -       "
> +'
>
>  cat >prop.expect <<\EOF
>
> @@ -207,7 +211,7 @@ test_expect_success 'test propget' '
>         test_propget svn:ignore nested/ ../prop.expect &&
>         test_propget svn:ignore ./nested ../prop.expect &&
>         test_propget svn:ignore .././deeply/nested ../prop.expect
> -       '
> +'
>
>  cat >prop.expect <<\EOF
>  Properties on '.':
> @@ -225,12 +229,12 @@ Properties on 'nested/directory/.keep':
>    svn:entry:uuid
>  EOF
>
> -test_expect_success 'test proplist' "
> +test_expect_success 'test proplist' '
>         git svn proplist . >actual &&
>         cmp prop.expect actual &&
>
>         git svn proplist nested/directory/.keep >actual &&
>         cmp prop2.expect actual
> -       "
> +'
>
>  test_done
> --
> 2.47.0.86.g15030f9556
>

Hi Taylor,

I trust you're well.

I didn't get any status update on the patch I updated the commit
message, found here:
https://public-inbox.org/git/20241102102801.26432-1-kuforiji98@gmail.com/

Is it good to go?

Thanks
Seyi

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2024-11-18  8:34 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-31  9:45 [PATCH] t9101: Refactor test_expect_success format Seyi Kuforiji
2024-10-31 20:15 ` Taylor Blau
2024-11-01  7:51   ` Seyi Chamber
2024-11-01 14:42     ` Taylor Blau
2024-11-02 10:28 ` [PATCH v2] " Seyi Kuforiji
2024-11-18  8:34   ` Seyi Chamber

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).