Re: [PATCH 15/26] help: fix leaking `struct cmdnames`

[Patrick Steinhardt <ps@pks.im>]

On Sun, Nov 10, 2024 at 10:46:29PM +0100, Rubén Justo wrote:
> On Wed, Nov 06, 2024 at 04:11:03PM +0100, Patrick Steinhardt wrote:
> > @@ -630,7 +631,7 @@ const char *help_unknown_cmd(const char *cmd)
> >  
> >  	if (cfg.autocorrect == AUTOCORRECT_NEVER) {
> >  		fprintf_ln(stderr, _("git: '%s' is not a git command. See 'git --help'."), cmd);
> > -		exit(1);
> > +		goto out;
> 
> We haven't set a value for `assumed` at this point, so it's NULL, and in the
> new exit path we `exit(1)` when `assumed` is NULL.  OK.
> 
> However, I think we don't need this change.  And keeping the `exit(1)` close to
> the error message seems like a good idea.  Perhaps, in another series, we could
> change it to `die()`.

Yeah, good point indeed. I'll adapt this.

Patrick