Git development
 help / color / mirror / Atom feed
From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Jeff King <peff@peff.net>
Cc: Sam James <sam@gentoo.org>, git@vger.kernel.org
Subject: Re: -Wunterminated-string-initialization warning with GCC 15 in object-file.c
Date: Sun, 17 Nov 2024 16:03:31 +0000	[thread overview]
Message-ID: <ZzoT03rsx7MTqSFl@tapette.crustytoothpaste.net> (raw)
In-Reply-To: <20241117090329.GA2341486@coredump.intra.peff.net>

[-- Attachment #1: Type: text/plain, Size: 828 bytes --]

On 2024-11-17 at 09:03:29, Jeff King wrote:
> Here are some patches. The first one should fix the warning (but I don't
> have gcc-15 handy to test!). Please let me know if it works for you (and
> thank you for reporting).

Just so you know, since I believe you also use Debian unstable, you can
install the gcc-snapshot package (which is, admittedly, rather large)
and use `CC=/usr/lib/gcc-snapshot/bin/gcc`.

> The others are cleanups and future-proofing I found in the same area.
> Not strictly required, but IMHO worth doing.
> 
> +cc brian since I think this is a continuation of some hash-algo
> cleanups he did earlier, plus he piped up in the other gcc-15 thread. ;)

Other than the issue that René noticed, this seems reasonable to me.
-- 
brian m. carlson (they/them or he/him)
Toronto, Ontario, CA

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

  parent reply	other threads:[~2024-11-17 16:03 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-17  2:50 -Wunterminated-string-initialization warning with GCC 15 in object-file.c Sam James
2024-11-17  9:03 ` Jeff King
2024-11-17  9:08   ` [PATCH 1/5] object-file: prefer array-of-bytes initializer for hash literals Jeff King
2024-11-17  9:52     ` René Scharfe
2024-11-18  9:06       ` Jeff King
2024-11-17  9:08   ` [PATCH 2/5] object-file: drop confusing oid initializer of empty_tree struct Jeff King
2024-11-17  9:08   ` [PATCH 3/5] object-file: move empty_tree struct into find_cached_object() Jeff King
2024-11-18  7:40     ` Patrick Steinhardt
2024-11-18  9:17       ` Jeff King
2024-11-17  9:10   ` [PATCH 4/5] object-file: drop oid field from find_cached_object() return value Jeff King
2024-11-17  9:14   ` [PATCH 5/5] object-file: inline empty tree and blob literals Jeff King
2024-11-18  7:40     ` Patrick Steinhardt
2024-11-17 16:03   ` brian m. carlson [this message]
2024-11-18  9:19     ` -Wunterminated-string-initialization warning with GCC 15 in object-file.c Jeff King
2024-11-18  9:58       ` Sam James
2024-11-18  7:40   ` Patrick Steinhardt
2024-11-18  9:54   ` [PATCH 0/6] -Wunterminated-string-initialization warning + cleanups Jeff King
2024-11-18  9:54     ` [PATCH 1/6] object-file: prefer array-of-bytes initializer for hash literals Jeff King
2024-11-18  9:55     ` [PATCH 2/6] object-file: drop confusing oid initializer of empty_tree struct Jeff King
2024-11-18  9:55     ` [PATCH 3/6] object-file: move empty_tree struct into find_cached_object() Jeff King
2024-11-18  9:55     ` [PATCH 4/6] object-file: drop oid field from find_cached_object() return value Jeff King
2024-11-18  9:55     ` [PATCH 5/6] object-file: treat cached_object values as const Jeff King
2024-11-18  9:55     ` [PATCH 6/6] object-file: inline empty tree and blob literals Jeff King
2024-11-18 10:51     ` [PATCH 0/6] -Wunterminated-string-initialization warning + cleanups Patrick Steinhardt
2024-11-18 12:49       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZzoT03rsx7MTqSFl@tapette.crustytoothpaste.net \
    --to=sandals@crustytoothpaste.net \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=sam@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox