* [StGit BUG/PATCH] config.py: fix unset
@ 2009-08-06 3:29 Chris Packham
0 siblings, 0 replies; only message in thread
From: Chris Packham @ 2009-08-06 3:29 UTC (permalink / raw)
To: git
From: Chris Packham <judge.packham@gmail.com>
Missing invocation of .run() so config.unset('blah') didn't do anything.
Consequently the fact that the next line set the value to 'None' instead of a
list with 1 element i.e. '[None]' was not noticed.
Signed-off-by: Chris Packham <judge.packham@gmail.com>
---
stgit/config.py | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/stgit/config.py b/stgit/config.py
index 4a6cb3b..6f84b10 100644
--- a/stgit/config.py
+++ b/stgit/config.py
@@ -94,8 +94,8 @@ class GitConfig:
self.__cache[name] = value
def unset(self, name):
- Run('git', 'config', '--unset', name)
- self.__cache[name] = None
+ Run('git', 'config', '--unset', name).run()
+ self.__cache[name] = [None]
def sections_matching(self, regexp):
"""Takes a regexp with a single group, matches it against all
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2009-08-06 3:36 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-06 3:29 [StGit BUG/PATCH] config.py: fix unset Chris Packham
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).