git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Packham <judge.packham@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Jeff King" <peff@peff.net>, "SZEDER Gábor" <szeder@ira.uka.de>,
	git@vger.kernel.org
Subject: Re: git add -u nonexistent-file
Date: Tue, 9 Feb 2010 17:17:54 -0500	[thread overview]
Message-ID: <a038bef51002091417o1048c098x898517596115ed90@mail.gmail.com> (raw)
In-Reply-To: <7v7hqm2hs7.fsf@alter.siamese.dyndns.org>

On Tue, Feb 9, 2010 at 4:58 PM, Junio C Hamano <gitster@pobox.com> wrote:
>
> It won't be entirely trivial to do so efficiently but it shouldn't be a
> rocket surgery.
>
> Something like this (untested of course)?
>

Passes my new test and all the rest in t2200-add-update.sh and t3700-add.sh.

Hows this for a commit message:

  git add -u: give an error if pathspec unmatched

  If a pathspec is supplied to 'git add -u' and no matching path is
  matched, fail with an approriate error message and exit code.

  reply	other threads:[~2010-02-09 22:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-08 18:29 git add -u nonexistent-file SZEDER Gábor
2010-02-08 19:12 ` Chris Packham
2010-02-09  0:39   ` Jeff King
2010-02-09 14:43     ` Chris Packham
2010-02-09 21:31       ` [PATCH] test for add with non-existent pathspec Chris Packham
2010-02-09 21:58     ` git add -u nonexistent-file Junio C Hamano
2010-02-09 22:17       ` Chris Packham [this message]
2010-02-09 22:30         ` Chris Packham
2010-02-09 22:30           ` [PATCH 1/3] test for add with non-existent pathspec Chris Packham
2010-02-09 22:30             ` [PATCH 2/3] git add -u: give an error if pathspec unmatched Chris Packham
2010-02-09 22:30               ` [PATCH 3/3] t2200-add-update.sh: change expected fail to success Chris Packham
2010-02-09 23:18         ` git add -u nonexistent-file Junio C Hamano
2010-02-10  5:57       ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a038bef51002091417o1048c098x898517596115ed90@mail.gmail.com \
    --to=judge.packham@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=szeder@ira.uka.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).