git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Derrick Stolee <stolee@gmail.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>,
	Derrick Stolee <dstolee@microsoft.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] revision.c: fix sparse warnings (sparse algorithm)
Date: Tue, 15 Jan 2019 09:42:36 -0500	[thread overview]
Message-ID: <a0ace9a0-65f9-ad2e-26f8-b46e3ef0153e@gmail.com> (raw)
In-Reply-To: <0f69cce6-a0a0-8972-93dd-5c1aa428f508@ramsayjones.plus.com>

On 1/13/2019 3:55 PM, Ramsay Jones wrote:
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Derrick,
>
> If you need to re-roll your 'ds/push-sparse-tree-walk' branch, could
> you please squash this into the relevant patch [commit 9949aaeef4
> ("revision: implement sparse algorithm", 2018-12-14)].
>
> This commit caused both 'sparse' and my 'static-check.pl' script to
> complain about the visibility of the 'map_flags' variable (it is a
> file local variable), so one solution would be to mark it 'static'.
> However, it is simply not being used, so ...
>
> Thanks!
>
> ATB,
> Ramsay Jones

Thanks, Ramsay! I'm rerolling the series today, so I will make this change.

-Stolee


  reply	other threads:[~2019-01-15 14:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-13 20:55 [PATCH] revision.c: fix sparse warnings (sparse algorithm) Ramsay Jones
2019-01-15 14:42 ` Derrick Stolee [this message]
2019-01-15 18:29   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a0ace9a0-65f9-ad2e-26f8-b46e3ef0153e@gmail.com \
    --to=stolee@gmail.com \
    --cc=dstolee@microsoft.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=ramsay@ramsayjones.plus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).