git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: git@vger.kernel.org
Subject: [PATCH 1/2] git-send-email.perl: Don't add header "In-Reply-To:" when --no-chain-reply-to set
Date: Tue, 30 Jun 2009 16:40:38 -0700	[thread overview]
Message-ID: <a19204c574f407d98be74d54cfd899b43fdc7d26.1246404999.git.joe@perches.com> (raw)
In-Reply-To: <cover.1246404999.git.joe@perches.com>

using
  git format-patch --thread=shallow -o <foo>
and
  git send-email --no-thread --no-chain-reply-to <foo>

duplicates the headers

  In-Reply-To:
  References:

Signed-off-by: Joe Perches <joe@perches.com>
---
 git-send-email.perl |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/git-send-email.perl b/git-send-email.perl
index 8ce6f1f..1b9b27e 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -1151,7 +1151,8 @@ foreach my $t (@files) {
 
 	# set up for the next message
 	if ($thread && $message_was_sent &&
-		($chain_reply_to || !defined $reply_to || length($reply_to) == 0)) {
+	    ($chain_reply_to && 
+	     (!defined $reply_to || length($reply_to) == 0))) {
 		$reply_to = $message_id;
 		if (length $references > 0) {
 			$references .= "\n $message_id";
-- 
1.6.3.1.10.g659a0.dirty

  reply	other threads:[~2009-06-30 23:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-30 23:40 [PATCH 0/2] format-patch and send-email Joe Perches
2009-06-30 23:40 ` Joe Perches [this message]
2009-07-01  6:18   ` [PATCH 1/2] git-send-email.perl: Don't add header "In-Reply-To:" when --no-chain-reply-to set Markus Heidelberg
2009-07-01  6:27     ` Joe Perches
2009-07-01 16:59       ` Markus Heidelberg
2009-07-01 17:25         ` Joe Perches
2009-06-30 23:40 ` [PATCH 2/2] format-patch: Add --cover-letter-wrap Joe Perches
2009-07-02  6:45   ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a19204c574f407d98be74d54cfd899b43fdc7d26.1246404999.git.joe@perches.com \
    --to=joe@perches.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).