git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ulrik Sverdrup" <ulrik.sverdrup@gmail.com>
To: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH] git-archive: ignore prefix when checking file attribute
Date: Thu, 10 Apr 2008 00:58:26 +0200	[thread overview]
Message-ID: <a1b6cb1b0804091558r42b365cbjf216b3a5167588cf@mail.gmail.com> (raw)
In-Reply-To: <47FD31C3.8070001@lsrfire.ath.cx>

2008/4/9, René Scharfe <rene.scharfe@lsrfire.ath.cx>:
> Ulrik Sverdrup noticed that git-archive doesn't correctly apply the attribute
>  export-subst when the option --prefix is given, too.
>
>  When it checked if a file has the attribute turned on, git-archive would try
>  to look up the full path -- including the prefix -- in .gitattributes.  That's
>  wrong, as the prefix doesn't need to have any relation to any existing
>  directories, tracked or not.
>
>  This patch makes git-archive ignore the prefix when looking up if value of the
>  attribute export-subst for a file.
>
>  Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
>  ---
>  Ulrik, does this patch fix the problem for you?  It applies to v1.5.4.4 and
>  v1.5.5 equally.


Thanks for the patch René!

First I reproduced my problem on vanilla git v1.5.5, and it is still
there as in v.1.5.4.4.
I applied this patch and that fixed my issue, testing both tar and zip.

Ulrik Sverdrup

  reply	other threads:[~2008-04-09 22:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-08 21:35 Bug: git archive not doing export-subst when using --prefix= option Ulrik Sverdrup
2008-04-09 21:14 ` [PATCH] git-archive: ignore prefix when checking file attribute René Scharfe
2008-04-09 22:58   ` Ulrik Sverdrup [this message]
2008-04-10 10:56   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a1b6cb1b0804091558r42b365cbjf216b3a5167588cf@mail.gmail.com \
    --to=ulrik.sverdrup@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=rene.scharfe@lsrfire.ath.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).