From: "Dmitry Kakurin" <dmitry.kakurin@gmail.com>
To: "Steffen Prohaska" <prohaska@zib.de>
Cc: "Git Mailing List" <git@vger.kernel.org>,
"Johannes Sixt" <j.sixt@viscovery.net>,
"Junio C Hamano" <gitster@pobox.com>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH 3/3] Replace setenv(GIT_DIR_ENVIRONMENT, ...) with set_git_dir()
Date: Wed, 2 Jan 2008 20:07:35 -0800 [thread overview]
Message-ID: <a1bbc6950801022007w164d050bhf8a8a8c0ad6736b@mail.gmail.com> (raw)
In-Reply-To: <0FFA1D0A-DB70-446C-9C43-A6FBAEFE7CA4@zib.de>
On Jan 1, 2008 10:52 AM, Steffen Prohaska <prohaska@zib.de> wrote:
> In conclusion, using setenv() as in the original code instead of
> set_git_dir() should be safe and this patch is not needed.
>
> I tend to revert the changes in msysgit and see if we hit any
> problems. But I'll wait until 1.5.4 is released.
>
> Steffen
Please don't revert this change. I've made it in response to git clone
failing, commit 855f254b2b5b083a63fc8d7709a42e2cbdc5a136.
--
- Dmitry
next prev parent reply other threads:[~2008-01-03 4:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-21 20:27 [PATCH 0/3] msysgit fallout Steffen Prohaska
2007-11-21 20:27 ` [PATCH 1/3] sha1_file.c: Fix size_t related printf format warnings Steffen Prohaska
2007-11-21 20:27 ` [PATCH 2/3] builtin-init-db: use get_git_dir() instead of getenv() Steffen Prohaska
2007-11-21 20:27 ` [PATCH 3/3] Replace setenv(GIT_DIR_ENVIRONMENT, ...) with set_git_dir() Steffen Prohaska
2007-11-22 1:22 ` Johannes Schindelin
2007-11-22 2:34 ` Junio C Hamano
2007-11-22 6:13 ` Steffen Prohaska
2007-11-22 7:52 ` Junio C Hamano
2007-11-22 8:31 ` Steffen Prohaska
2007-11-22 9:58 ` Johannes Sixt
2007-11-22 17:56 ` Steffen Prohaska
2007-11-22 22:09 ` Johannes Schindelin
2008-01-01 18:52 ` Steffen Prohaska
2008-01-03 4:07 ` Dmitry Kakurin [this message]
2008-01-03 6:02 ` Steffen Prohaska
2008-01-03 6:26 ` Dmitry Kakurin
2008-01-03 7:53 ` Steffen Prohaska
2007-11-22 7:29 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1bbc6950801022007w164d050bhf8a8a8c0ad6736b@mail.gmail.com \
--to=dmitry.kakurin@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=prohaska@zib.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).